public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager] ceph install wizard: fix #3597: don't autofill network
Date: Wed, 1 Jun 2022 12:27:32 +0200	[thread overview]
Message-ID: <ba483242-5e83-dc64-274b-d2fd7523dc80@proxmox.com> (raw)
In-Reply-To: <20220502140505.3082374-1-a.lauterer@proxmox.com>

Can someone take a look at this? Patch should still apply.

On 5/2/22 16:05, Aaron Lauterer wrote:
> By not auto filling the Ceph public network we can avoid accidential
> clicks on 'Next' which will cause the first Mon to be created with a
> potentially wrong network. While that is fixable, it is tedious and can
> be easily avoided by making the user always select the network to use.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>   www/manager6/ceph/CephInstallWizard.js | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js
> index 59458b0d..bebfc319 100644
> --- a/www/manager6/ceph/CephInstallWizard.js
> +++ b/www/manager6/ceph/CephInstallWizard.js
> @@ -372,6 +372,7 @@ Ext.define('PVE.ceph.CephInstallWizard', {
>   		    name: 'network',
>   		    value: '',
>   		    fieldLabel: 'Public Network IP/CIDR',
> +		    autoSelect: false,
>   		    bind: {
>   			allowBlank: '{configuration}',
>   		    },




  reply	other threads:[~2022-06-01 10:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-02 14:05 Aaron Lauterer
2022-06-01 10:27 ` Aaron Lauterer [this message]
2022-06-02 13:30   ` Stefan Hrdlicka
2022-06-08  7:04     ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba483242-5e83-dc64-274b-d2fd7523dc80@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal