From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pve-devel] [PATCH promxox-mail-forward] fix logging by switching to proxmox-log
Date: Fri, 13 Jun 2025 09:46:23 +0200 [thread overview]
Message-ID: <ba3ab666-b8f0-4d65-afc7-e4a701158d00@proxmox.com> (raw)
In-Reply-To: <tiyj4cvuftnivxten7lazqnuj2whwujnqce7tv3vziy33ekh6p@cs5zhodtxf6z>
On 2025-06-12 17:16, Gabriel Goller wrote:
> Printing anyhow errors with "{:#}" would be nice, so that the whole
> context is visible as well.
>
> Otherwise LGTM!
> Consider:
> Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
Good point, I'll add the alternative formatter and add your R-b at the same time for a v2.
Thanks for the review!
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-13 7:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 12:34 Lukas Wagner
2025-06-12 15:16 ` Gabriel Goller
2025-06-13 7:46 ` Lukas Wagner [this message]
2025-06-13 7:56 ` [pve-devel] superseded: " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba3ab666-b8f0-4d65-afc7-e4a701158d00@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal