From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>,
Shan Shaji <s.shaji@proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox_login_manager] ui: settings: add privacy policy url link in settings screen
Date: Fri, 4 Jul 2025 11:34:35 +0200 [thread overview]
Message-ID: <b9a3a5cc-be3b-4b92-83bf-145b04a6563e@proxmox.com> (raw)
In-Reply-To: <f375c071-c7e1-4b19-afa2-3e89d53e0643@proxmox.com>
Am 04.07.25 um 09:31 schrieb Dominik Csapak:
>>
>> This is just my doubt. Can i ask why we seperated the
>> proxmox_login_manager as a seperate package?
> I'm not sure why we did this, but my guess would be that it was planned to maybe have
> multiple apps in the future?
>
> @Tim i think you were intially the one doing that, do you remember why we did the split?
>
For having a shared basis for other products, there is a prototype for
PBS on the staff repos IIRC. While we do not plan to develop that further
at the moment, having to split it out again in the future is definitively
quite a bit of extra work, while keeping it split shouldn't be so hard
I think. So, while not a must, I'd I'd keep it split for the time being,
if there are no bigger reasons speaking against that.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-04 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 11:19 Shan Shaji
2025-07-03 14:00 ` Dominik Csapak
2025-07-04 7:16 ` Shan Shaji
2025-07-04 7:31 ` Dominik Csapak
2025-07-04 9:34 ` Thomas Lamprecht [this message]
2025-07-04 12:11 ` Shan Shaji
2025-07-04 14:40 ` Shan Shaji
2025-07-07 6:28 ` Dominik Csapak
2025-07-07 7:09 ` Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9a3a5cc-be3b-4b92-83bf-145b04a6563e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox