From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Tschlatscher <d.tschlatscher@proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit] fix #3994: Node config options in the GUI
Date: Fri, 22 Apr 2022 12:12:10 +0200 [thread overview]
Message-ID: <b984c56d-ff44-28b0-142c-cefe6e1b8ea0@proxmox.com> (raw)
In-Reply-To: <20220420100916.67799-2-d.tschlatscher@proxmox.com>
On 20.04.22 12:09, Daniel Tschlatscher wrote:
> Added a new file for displaying and editing the node config options
> which were not exposed through the GUI yet. Namely those are the
> settings for wakeonlan and startall-on-boot-delay.
Why is this in widget toolkit if it's only PVE specific? (see below)
I'd just add it in pve-manager, no point in adding the headache of splitting a feature
over multiple packages if it cannot be reused anyway.
> Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
> ---
> src/Makefile | 1 +
> src/node/OptionsView.js | 85 +++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 86 insertions(+)
> create mode 100644 src/node/OptionsView.js
>
> diff --git a/src/Makefile b/src/Makefile
> index dd7729e..0217ae1 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -96,6 +96,7 @@ JSSRC= \
> node/DNSEdit.js \
> node/HostsView.js \
> node/DNSView.js \
> + node/OptionsView.js \
> node/Tasks.js \
> node/ServiceView.js \
> node/TimeEdit.js \
> diff --git a/src/node/OptionsView.js b/src/node/OptionsView.js
> new file mode 100644
> index 0000000..3d1e7bb
> --- /dev/null
> +++ b/src/node/OptionsView.js
> @@ -0,0 +1,85 @@
> +Ext.define('Proxmox.node.OptionsView', {
> + extend: 'Proxmox.grid.ObjectGrid',
> + alias: ['widget.proxmoxNodeOptionsView'],
> +
> + gridRows: [
> + {
> + xtype: 'integer',
> + name: 'startall-onboot-delay',
pve specific
> + text: gettext('Start on boot delay'),
> + minValue: 0,
> + maxValue: 300,
> + labelWidth: 130,
> + deleteEmpty: true,
> + renderer: function(value) {
> + if (value === undefined) {
> + return Proxmox.Utils.defaultText;
> + }
> +
> + let secString = value === 1 ? gettext('Second') : gettext('Seconds');
> + return `${value} ${secString}`;
> + },
> + },
> + {
> + xtype: 'text',
> + name: 'wakeonlan',
pve specific
> + text: gettext('Wake on LAN'),
> + vtype: 'MacAddress',
> + deleteEmpty: true,
> + renderer: function(value) {
> + if (value === undefined) {
> + return Proxmox.Utils.NoneText;
> + }
> +
> + return value;
> + },
> + },
> + ],
> +
> + initComponent: function() {
> + let me = this;
> + let baseUrl = `/nodes/${me.nodename}/config`;
you use nodename before you check that it's set, not that it matters much but it's just not
/that/ nice code-style wise (things tend to get copied and adapted, which such unnecessary
subtleties may cause headache with).
> +
> + if (!me.nodename) {
> + throw "no node name specified";
> + }
> +
> + let editBtn = new Ext.Button({
> + text: gettext('Edit'),
> + disabled: true,
> + handler: function() { me.run_editor(); },
> + });
> +
> +
> + let setButtonStatus = function() {
> + let sm = me.getSelectionModel();
> + let rec = sm.getSelection()[0];
> +
> + if (!rec) {
> + editBtn.disable();
> + return;
> + }
> +
> + let rowdef = me.rows[rec.data.key];
> + editBtn.setDisabled(!rowdef.editor);
> + };
> +
> + Ext.apply(me, {
> + url: `/api2/json${baseUrl}`,
> + tbar: [editBtn],
> + editorConfig: {
> + url: `/api2/extjs/${baseUrl}`,
> + },
> + listeners: {
> + itemdblclick: me.run_editor,
> + selectionchange: setButtonStatus,
> + },
> + });
> +
> + me.callParent();
> +
> + me.on('activate', me.rstore.startUpdate);
> + me.on('deactivate', me.rstore.stopUpdate);
> + me.on('destroy', me.rstore.stopUpdate);
you could try using a view controller for above, that could theoretically also allow to drop the whole
initComponents. (search the code base for `ViewController`); not a requirement but good to check out
as learning purpose and maybe you like it better.
next prev parent reply other threads:[~2022-04-22 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 10:09 [pve-devel] [PATCH docs] fix #3994: Added blockid to chapter Proxmox Node Management Daniel Tschlatscher
2022-04-20 10:09 ` [pve-devel] [PATCH widget-toolkit] fix #3994: Node config options in the GUI Daniel Tschlatscher
2022-04-22 10:12 ` Thomas Lamprecht [this message]
2022-04-20 10:09 ` [pve-devel] [PATCH manager] fix #3994: Options menu entry in the System menu Daniel Tschlatscher
2022-04-22 9:42 ` [pve-devel] applied: [PATCH docs] fix #3994: Added blockid to chapter Proxmox Node Management Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b984c56d-ff44-28b0-142c-cefe6e1b8ea0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox