From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH novnc] add patches to workaround fullscreen issue in android app
Date: Tue, 21 Dec 2021 11:41:18 +0100 [thread overview]
Message-ID: <b98185e0-513e-95de-5d72-7b9955728e62@proxmox.com> (raw)
In-Reply-To: <20211220113300.3090910-1-d.csapak@proxmox.com>
On 20/12/2021 12:33, Dominik Csapak wrote:
> patch 15 hides the fullscreen button,
> patch 16 make the error message dismissable
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> ...-button-on-isFullscreen-get-variable.patch | 39 +++++++++++++++
> debian/patches/0017-make-error-hideable.patch | 47 +++++++++++++++++++
> debian/patches/series | 2 +
> 3 files changed, 88 insertions(+)
> create mode 100644 debian/patches/0016-hide-fullscreen-button-on-isFullscreen-get-variable.patch
> create mode 100644 debian/patches/0017-make-error-hideable.patch
>
>
now with the 1.3 rebase done first this applied cleanly, thanks!
FYI: I adapted the commit message so that the patch references are correct there.
IMO the "make error dismissable" should be upstreamed in some form, not sure if
clicking on it is the best general solution, as that can make copying an error
text hard, but either a X (text-)button or the like would surely be great for
them too.
prev parent reply other threads:[~2021-12-21 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 11:33 [pve-devel] " Dominik Csapak
2021-12-20 19:53 ` Thomas Lamprecht
2021-12-21 7:05 ` Dominik Csapak
2021-12-21 8:27 ` Thomas Lamprecht
2021-12-21 10:41 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b98185e0-513e-95de-5d72-7b9955728e62@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox