Re: [pve-devel] [PATCH pve-installer 4/6] run rustfmt

["Michael Köppl" <m.koeppl@proxmox.com>]

On 4/23/25 13:56, Christoph Heiss wrote:
> Have you checked out the latest commit (952832147)?
> 
> These are apparently the "old" 2021 edition rules which are being
> applied here - latest master is on the 2024 edition for some time now
> [0]. The changes here are the exact reverse of some of the changes done
> in the follow-up tree-wide formatting commit [1].
> 
> (Also, running `cargo fmt` on latest master does not produce any
> changes, FWIW. So this should not be necessary - that's what caught me.)
> 
> [0] https://git.proxmox.com/?p=pve-installer.git;a=commitdiff;h=c305be5e
> [1] https://git.proxmox.com/?p=pve-installer.git;a=commitdiff;h=a1575df4
> 

Hi, thanks for having a look and for your feedback! It seems this stems 
from a configuration issue with my Neovim. For some reason the rustfmt 
used by my editor plugin did not pick up the edition = "2024" in 
rustfmt.toml. FWIW, it did work when I instead set style_edition = 
"2024", which allows explicitly setting the style used for formatting 
according to the Rust documentation [0]. I suppose it's more of a 
configuration error on my side, though. I checked again to ensure the 
other patches are not affected. I suppose this one could just be 
omitted? Or should I send a new series?

[0] 
https://doc.rust-lang.org/edition-guide/rust-2024/rustfmt-style-edition.html


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel