From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage v5 02/12] plugin: dir: implement import content type
Date: Fri, 15 Nov 2024 12:44:27 +0100 [thread overview]
Message-ID: <b9082e36-704a-4f62-916c-32a6586357bb@proxmox.com> (raw)
In-Reply-To: <78b274cf-2412-4290-90c5-a5c84bd9a4fa@proxmox.com>
On 11/15/24 12:24, Fiona Ebner wrote:
> On 15.11.24 12:16 PM, Fiona Ebner wrote:
>> On 14.11.24 10:32 AM, Dominik Csapak wrote:
>>> +
>>> + my ($vtype, $name, undef, undef, undef, undef, $fmt) = $class->parse_volname($volname);
>>> + die "invalid content type '$vtype'\n" if $vtype ne 'import';
>>> + die "invalid format\n" if $fmt ne 'ova' && $fmt ne 'ovf';
>>
>> The $IMPORT_EXT_RE_1 regex doesn't include 'ova' anymore. Is it still
>> wanted here?
>
> Okay, I guess strictly speaking it would go into the next patch ;)
ah ok, this probably happened on some rebase
since i probably have to send a v6 anyway, i'd move the ova check
in the next patch that includes ova in the IMPORT_EXT_RE_1 ?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-15 11:45 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 9:32 [pve-devel] [PATCH storage/qemu-server/manager v5] implement ova/ovf import for file based storages Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 01/12] copy OVF.pm from qemu-server Dominik Csapak
2024-11-15 10:37 ` Fiona Ebner
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 02/12] plugin: dir: implement import content type Dominik Csapak
2024-11-15 11:16 ` Fiona Ebner
2024-11-15 11:24 ` Fiona Ebner
2024-11-15 11:44 ` Dominik Csapak [this message]
2024-11-15 11:47 ` Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 03/12] plugin: dir: handle ova files for import Dominik Csapak
2024-11-15 12:11 ` Fiona Ebner
2024-11-15 13:06 ` Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 04/12] ovf: improve and simplify path checking code Dominik Csapak
2024-11-15 13:35 ` Fiona Ebner
2024-11-15 13:39 ` Dominik Csapak
2024-11-15 13:44 ` Fiona Ebner
2024-11-15 13:56 ` Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 05/12] ovf: implement parsing the ostype Dominik Csapak
2024-11-15 13:39 ` Fiona Ebner
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 06/12] ovf: implement parsing out firmware type Dominik Csapak
2024-11-15 13:44 ` Fiona Ebner
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 07/12] ovf: implement rudimentary boot order Dominik Csapak
2024-11-15 13:46 ` Fiona Ebner
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 08/12] ovf: implement parsing nics Dominik Csapak
2024-11-15 13:52 ` Fiona Ebner
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 09/12] api: allow ova upload/download Dominik Csapak
2024-11-15 14:27 ` Fiona Ebner
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 10/12] plugin: enable import for nfs/btrfs/cifs/cephfs/glusterfs Dominik Csapak
2024-11-15 14:28 ` Fiona Ebner
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 11/12] add 'import' content type to 'check_volume_access' Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH storage v5 12/12] plugin: file_size_info: don't ignore base path with whitespace Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH qemu-server v5 1/4] api: delete unused OVF.pm Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH qemu-server v5 2/4] use OVF from Storage Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH qemu-server v5 3/4] api: create: implement extracting disks when needed for import-from Dominik Csapak
2024-11-15 7:06 ` Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH qemu-server v5 4/4] api: create: add 'import-extraction-storage' parameter Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 1/9] ui: fix special 'import' icon for non-esxi storages Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 2/9] ui: guest import: add ova-needs-extracting warning text Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 3/9] ui: enable import content type for relevant storages Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 4/9] ui: enable upload/download/remove buttons for 'import' type storages Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 5/9] ui: disable 'import' button for non importable formats Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 6/9] ui: import: improve rendering of volume names Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 7/9] ui: guest import: add storage selector for ova extraction storage Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 8/9] ui: guest import: change icon/text for non-esxi import storage Dominik Csapak
2024-11-14 9:32 ` [pve-devel] [PATCH manager v5 9/9] ui: import: show size for dir-based storages Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH storage/qemu-server/manager v5] implement ova/ovf import for file based storages Fiona Ebner
2024-11-15 15:22 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9082e36-704a-4f62-916c-32a6586357bb@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox