From: Fiona Ebner <f.ebner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 storage 6/9] rbd plugin: implement new method to get qemu blockdevice options
Date: Tue, 1 Jul 2025 14:15:14 +0200 [thread overview]
Message-ID: <b9058df0-a1ac-47fc-97c2-5db85c11c71b@proxmox.com> (raw)
In-Reply-To: <1751282340.4gscq50eyh.astroid@yuna.none>
Am 30.06.25 um 13:19 schrieb Fabian Grünbichler:
> On June 26, 2025 4:40 pm, Fiona Ebner wrote:
>> The mon host parsing is adapted from other places. While there
>> currently is no support for vector notation in the storage config
>> (it's a pve-storage-portal-dns-list option), it doesn't hurt to
>> anticipate it, should the list of mon hosts come from a ceph.conf
>> instead anytime in the future.
>
> but in `path` we don't do this? shouldn't this be consistent?
Okay, I'll drop it in v4.
> also, we already have a full helper for getting a mon list from a ceph
> config, so if we ever use that as source here, shouldn't we use that
> helper?
Would need to be adapted a bit (to avoid joining+splitting), but sure.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-01 12:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 14:40 [pve-devel] [PATCH-SERIES v3 storage 0/9] storage plugin method to get qemu blockdevice options for volume Fiona Ebner
2025-06-26 14:40 ` [pve-devel] [PATCH v3 storage 1/9] plugin: add " Fiona Ebner
2025-07-01 9:28 ` Thomas Lamprecht
2025-07-01 11:01 ` Fiona Ebner
2025-07-01 11:09 ` Fabian Grünbichler
2025-07-02 8:27 ` Thomas Lamprecht
2025-07-02 8:40 ` Fabian Grünbichler
2025-07-01 11:52 ` Fiona Ebner
2025-07-02 8:12 ` Thomas Lamprecht
2025-07-02 8:32 ` Fiona Ebner
2025-06-26 14:40 ` [pve-devel] [PATCH v3 storage 2/9] iscsi direct plugin: implement method to get qemu blockdevice options Fiona Ebner
2025-06-26 14:40 ` [pve-devel] [PATCH v3 storage 3/9] zfs iscsi plugin: implement new " Fiona Ebner
2025-06-26 14:40 ` [pve-devel] [PATCH v3 storage 4/9] zfs pool plugin: implement " Fiona Ebner
2025-06-30 11:20 ` Fabian Grünbichler
2025-07-01 12:08 ` Fiona Ebner
2025-06-26 14:40 ` [pve-devel] [RFC v3 storage 5/9] ceph/rbd: set 'keyring' in ceph configuration for externally managed RBD storages Fiona Ebner
2025-06-26 14:40 ` [pve-devel] [PATCH v3 storage 6/9] rbd plugin: implement new method to get qemu blockdevice options Fiona Ebner
2025-06-30 11:19 ` Fabian Grünbichler
2025-07-01 12:15 ` Fiona Ebner [this message]
2025-06-26 14:40 ` [pve-devel] [RFC v3 storage 7/9] plugin: qemu block device: add hints option and EFI disk hint Fiona Ebner
2025-06-26 14:40 ` [pve-devel] [RFC v3 storage 8/9] plugin: qemu block device: add support for snapshot option Fiona Ebner
2025-06-30 11:40 ` Fabian Grünbichler
2025-07-01 12:23 ` Fiona Ebner
2025-06-26 14:40 ` [pve-devel] [PATCH v3 storage 9/9] plugin api: bump api version and age Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9058df0-a1ac-47fc-97c2-5db85c11c71b@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox