public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 qemu] block/gluster: provider more context for deprecation warning
Date: Wed, 2 Jul 2025 14:36:14 +0200	[thread overview]
Message-ID: <b8ff4e44-ea07-48ec-87b3-93fcf4f1218f@proxmox.com> (raw)
In-Reply-To: <5c0de667-97fa-4c50-b41d-83b05b8e7777@proxmox.com>

Am 25.06.25 um 19:18 schrieb Thomas Lamprecht:
> Am 02.06.25 um 13:07 schrieb Fiona Ebner:
>> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Changes in v2:
>> * Instead of removing the warning, provide more context.
>>
>>  block/gluster.c | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/block/gluster.c b/block/gluster.c
>> index c3a9555591..71c4a60b02 100644
>> --- a/block/gluster.c
>> +++ b/block/gluster.c
>> @@ -816,7 +816,11 @@ static int qemu_gluster_open(BlockDriverState *bs,  QDict *options,
>>          goto out;
>>      }
>>  
>> -    warn_report_once("'gluster' is deprecated");
>> +    warn_report_once("Native 'gluster' support will be deprecated and removed"
>> +                     " in Proxmox VE 9.");
>> +    warn_report_once("Before upgrading, switch to accessing your Gluster"
>> +                     " storage as a directory storage or migrate to another"
>> +                     " storage type.");
>>  
>>      filename = qemu_opt_get(opts, GLUSTER_OPT_FILENAME);
>>  
> 
> Acked-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> 
> can you please apply this on the stable-bookworm and upload
> a new version so that we can get this warning out over the
> next few weeks? Maybe there are some stable fixes that make
> a bump more worthwhile, but no hard feelings there.

Applied adding in your trailers and uploaded a new version now.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-07-02 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02 11:07 [pve-devel] " Fiona Ebner
2025-06-25 17:18 ` Thomas Lamprecht
2025-07-02 12:36   ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8ff4e44-ea07-48ec-87b3-93fcf4f1218f@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal