From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Philipp Hufnagl <p.hufnagl@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v3] ui: improve user experience for vm/container transfer between pools
Date: Wed, 13 Sep 2023 07:58:47 +0200 [thread overview]
Message-ID: <b8c0111f-b6f5-49dc-b30a-83801a685a65@proxmox.com> (raw)
In-Reply-To: <20230908131841.991706-1-p.hufnagl@proxmox.com>
Am 08/09/2023 um 15:18 schrieb Philipp Hufnagl:
> After the implementation of fix #474, it has been suggested that
> instead of requiring the user to click a checkbox allowing migration,
> it should be allowed automatically and and a warning should be displayed
>
> Further it has been discussed to rename the feature from "transfer" to
> "migrate". However and API change would break already implemented usage
> and so it has been decided to call it (for now) transfer everywhere to
>
> Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
> ---
Missing description of changes since previous patch version here.
Also missing defining the API defaults like asked multiple times, but I
pushed out a changeset [0] to address most of this on Friday before you
sent the v2, so that I was able to bump pve-manager for some other, a
bit pressing, bug fixes w.r.t. notifications stuff that Lukas sent in a
timely manner.
After rethinking it, I also renamed the APÌ parameter. As the package
that added the new parameter was only on pvetest I saw no real concerns
for practical ABI breakage, especially as this is a bit of a niche feature
(so @all please do not use this as general precedence, such things should
be considered case-by-case).
[0]: https://git.proxmox.com/?p=pve-manager.git;a=shortlog;h=57490ff2c6a38448d511d32ec1b4c9bc825545d9
prev parent reply other threads:[~2023-09-13 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 13:18 Philipp Hufnagl
2023-09-13 5:58 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8c0111f-b6f5-49dc-b30a-83801a685a65@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=p.hufnagl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox