public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH proxmox-ve] add grub.d snippet
@ 2021-06-24 10:57 Fabian Grünbichler
  2021-06-24 11:10 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Grünbichler @ 2021-06-24 10:57 UTC (permalink / raw)
  To: pve-devel

to set distributor and disable os-prober. this allows us to drop grub
cfg handling from the installer except for the ZFS on / use case.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---

Notes:
    adding the root=ZFS=.. boot=zfs to the kernel cmdline could also be done in the
    installer with a snippet - by referencing $GRUB_DEFAULT_CMDLINE, like
    kdump-tools does:
    
    GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT other-options.."

 debian/grub/proxmox-ve.cfg | 2 ++
 debian/proxmox-ve.install  | 1 +
 2 files changed, 3 insertions(+)
 create mode 100644 debian/grub/proxmox-ve.cfg

diff --git a/debian/grub/proxmox-ve.cfg b/debian/grub/proxmox-ve.cfg
new file mode 100644
index 0000000..d10da36
--- /dev/null
+++ b/debian/grub/proxmox-ve.cfg
@@ -0,0 +1,2 @@
+GRUB_DISTRIBUTOR="Proxmox VE"
+GRUB_DISABLE_OS_PROBER=true
diff --git a/debian/proxmox-ve.install b/debian/proxmox-ve.install
index 5780d2a..406f575 100644
--- a/debian/proxmox-ve.install
+++ b/debian/proxmox-ve.install
@@ -1,2 +1,3 @@
 debian/apthook/10pveapthook etc/apt/apt.conf.d/
 debian/apthook/pve-apt-hook usr/share/proxmox-ve/
+debian/grub/proxmox-ve.cfg etc/default/grub.d/
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied:  [PATCH proxmox-ve] add grub.d snippet
  2021-06-24 10:57 [pve-devel] [PATCH proxmox-ve] add grub.d snippet Fabian Grünbichler
@ 2021-06-24 11:10 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-06-24 11:10 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fabian Grünbichler

On 24.06.21 12:57, Fabian Grünbichler wrote:
> to set distributor and disable os-prober. this allows us to drop grub
> cfg handling from the installer except for the ZFS on / use case.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> 
> Notes:
>     adding the root=ZFS=.. boot=zfs to the kernel cmdline could also be done in the
>     installer with a snippet - by referencing $GRUB_DEFAULT_CMDLINE, like
>     kdump-tools does:
>     
>     GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT other-options.."

would sound nicer IMO.

> 
>  debian/grub/proxmox-ve.cfg | 2 ++
>  debian/proxmox-ve.install  | 1 +
>  2 files changed, 3 insertions(+)
>  create mode 100644 debian/grub/proxmox-ve.cfg
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-24 11:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 10:57 [pve-devel] [PATCH proxmox-ve] add grub.d snippet Fabian Grünbichler
2021-06-24 11:10 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal