From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-ve] add grub.d snippet
Date: Thu, 24 Jun 2021 13:10:50 +0200 [thread overview]
Message-ID: <b8b03a69-9198-69b7-d801-7e427da534b6@proxmox.com> (raw)
In-Reply-To: <20210624105722.1844748-1-f.gruenbichler@proxmox.com>
On 24.06.21 12:57, Fabian Grünbichler wrote:
> to set distributor and disable os-prober. this allows us to drop grub
> cfg handling from the installer except for the ZFS on / use case.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Notes:
> adding the root=ZFS=.. boot=zfs to the kernel cmdline could also be done in the
> installer with a snippet - by referencing $GRUB_DEFAULT_CMDLINE, like
> kdump-tools does:
>
> GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT other-options.."
would sound nicer IMO.
>
> debian/grub/proxmox-ve.cfg | 2 ++
> debian/proxmox-ve.install | 1 +
> 2 files changed, 3 insertions(+)
> create mode 100644 debian/grub/proxmox-ve.cfg
>
>
applied, thanks!
prev parent reply other threads:[~2021-06-24 11:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 10:57 [pve-devel] " Fabian Grünbichler
2021-06-24 11:10 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8b03a69-9198-69b7-d801-7e427da534b6@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox