public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Christian Ebner <c.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-manager] pve7to8: fix broken pipe warning for dkms status invocation
Date: Fri, 4 Apr 2025 12:50:22 +0200	[thread overview]
Message-ID: <b8afe179-2196-41f1-afb9-2560583fe0e9@proxmox.com> (raw)
In-Reply-To: <20250328174828.46006-1-c.ebner@proxmox.com>

Am 28.03.25 um 18:48 schrieb Christian Ebner:
> The check for dkms kernel modules relies on the output of `dkms
> status`. dkms command invocation will perform the following sanity
> check:
> ```
> if [ ! -e <(echo) ]; then
>     warn $"dkms will not function properly if /proc is not mounted."
> fi
> ```
> 
> This check will however throw the following warning when SIGPIPE is
> set to be ignored:
> 
> ```
> sbin/dkms: line 2497: echo: write error: Broken pipe
> ```
> 
> While only cosmetic, this can be confusing. Therefore, temporarily
> enable SIGPIPE before calling dkms, restoring the originally setting
> afterwards.
> 
> Reported-by: Alexander Zeidler <a.zeidler@proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  PVE/CLI/pve7to8.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
>

applied, thanks!


Also backported this to stable-7 and bumped a new version there with
some small other fixes included that mostly help on upgrade; as while
PVE 7 is EOL in general, I'm fine with rolling out polishing to make
upgrade easier, as that takes away even more excuses for not upgrading
already.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-04-04 10:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28 17:48 [pve-devel] " Christian Ebner
2025-04-04 10:50 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8afe179-2196-41f1-afb9-2560583fe0e9@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal