From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] install: zfs: rename pre-existing `rpool` also if in degraded state
Date: Fri, 15 Nov 2024 16:51:08 +0100 [thread overview]
Message-ID: <b8854873-de6b-464d-b56a-a95e6c92d64f@proxmox.com> (raw)
In-Reply-To: <20241115153500.307528-1-c.ebner@proxmox.com>
Am 15.11.24 um 16:35 schrieb Christian Ebner:
> If a subset of disks associated with a pre-existing ZFS pool are
> selected for installation, the pool might still be importable
> (required for the rename) but will be in a `degraded` state.
> Currently, only pools in `online` state will be considered for
> renameing, leading a possibly clashing pool named `rpool` behind.
> Therefore, a reboot after installation will fail because of the
> duplicate names.
>
> To partially fix this behaviour, also rename `rpool` in `degraded`
> state.
>
> Note:
> This however does not cover the case when a pool can no longer be
> imported because the number of required replicas is not available.
> Renaming by zpool import is not possible for that case.
>
> Partially-fixes: 43591049 ("low-level: install: check for already-existing `rpool` on install")
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> Proxmox/Install.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-15 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 15:35 [pve-devel] " Christian Ebner
2024-11-15 15:51 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8854873-de6b-464d-b56a-a95e6c92d64f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox