From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shannon Sterz <s.sterz@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer v2] install: don't select a debian mirror based on the country anymore
Date: Wed, 17 Sep 2025 15:38:19 +0200 [thread overview]
Message-ID: <b8809f0d-7321-44f9-9c76-8507908ab338@proxmox.com> (raw)
In-Reply-To: <20250731091506.67573-1-s.sterz@proxmox.com>
Am 31.07.25 um 11:15 AM schrieb Shannon Sterz:
> newer isos ship with new deb822 style repository configurations in
> `/etc/apt/sources.list.d/debian.sources` which already use the now
> prefered cdn [1]. since setting a mirror like this does not work
> anymore due to this change, just remove it to keep using the prefered
> cdn.
>
> [1]:
> https://www.debian.org/releases/trixie/release-notes/upgrading.en.html#adding-apt-internet-sources
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
We could also go ahead and remove adding the mirror information to the
country hash in country.pl after this change.
html/country.htm also should be updated:
The Proxmox Installer automatically makes location-based optimizations,
like choosing the nearest mirror to download files from.
since it's not the Installer itself doing that anymore.
> ---
>
> changes since v1:
>
> - instead of adapting how we set mirrors to the new deb822 format,
> simply remove this code altogether in favor of using the cdn.
>
> Proxmox/Install.pm | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
> index 3159dcc..5d77821 100644
> --- a/Proxmox/Install.pm
> +++ b/Proxmox/Install.pm
> @@ -1316,12 +1316,6 @@ _EOD
> symlink("/usr/share/zoneinfo/$timezone", "$targetdir/etc/localtime");
> file_write_all("$targetdir/etc/timezone", "$timezone\n");
>
> - # set apt mirror
> - if (my $mirror = $iso_env->{locales}->{country}->{$country}->{mirror}) {
> - my $fn = "$targetdir/etc/apt/sources.list";
> - syscmd("sed -i 's/ftp\\.debian\\.org/$mirror/' '$fn'");
> - }
> -
> # create extended_states for apt (avoid cron job warning if that
> # file does not exist)
> file_write_all("$targetdir/var/lib/apt/extended_states", '');
> --
> 2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-17 13:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 9:15 Shannon Sterz
2025-09-17 13:38 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8809f0d-7321-44f9-9c76-8507908ab338@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox