From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] cfg2cmd: factor out ovmf drives printing
Date: Wed, 7 Dec 2022 10:02:02 +0100 [thread overview]
Message-ID: <b86d807c-79f5-b6b9-9563-6c9d9c803614@proxmox.com> (raw)
In-Reply-To: <d28361b6-a84c-8e15-7865-e18bc4c0f3d1@proxmox.com>
Am 06.12.22 um 18:11 schrieb Thomas Lamprecht:
> Am 02/12/2022 um 13:59 schrieb Fiona Ebner:
>> No functional change is intended.
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Popped out while trying the other approach mentioned in:
>> https://lists.proxmox.com/pipermail/pve-devel/2022-December/055091.html
>
> looks ok, having it in a separate method opens up a few more "line reduction without
> making it harder to understand" possibilities, e.g., the following diff would drop
> 21 lines, but reorder the var string a bit too - what do you think?
>
Seems like the tabs got converted to spaces in the diff somewhere along
the way. But other than the few lines that break the 100 char limit, it
looks ok to me :)
next prev parent reply other threads:[~2022-12-07 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 12:59 Fiona Ebner
2022-12-06 17:11 ` Thomas Lamprecht
2022-12-07 9:02 ` Fiona Ebner [this message]
2022-12-12 10:45 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b86d807c-79f5-b6b9-9563-6c9d9c803614@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox