From: "Jens Meißner" <meissner@b1-systems.de>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH] Add DNS challenge schema for knot.
Date: Thu, 18 Nov 2021 09:50:57 +0100 [thread overview]
Message-ID: <b869de82-6c08-f650-3a5e-1b78d059f01c@b1-systems.de> (raw)
In-Reply-To: <37e5ab74-119b-8839-3da8-2fd9eb72f580@proxmox.com>
[-- Attachment #1.1: Type: text/plain, Size: 1780 bytes --]
Am 17.11.21 um 17:27 schrieb Thomas Lamprecht:
> looks OK in general, one question inline...
>
> On 17.11.21 09:03, Jens Meißner wrote:
>> Signed-off-by: Jens Meißner <meissner@b1-systems.de>
>> ---
>> src/dns-challenge-schema.json | 19 ++++++++++++++++++-
>> 1 file changed, 18 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/dns-challenge-schema.json b/src/dns-challenge-schema.json
>> index a3a3ebc..d194701 100644
>> --- a/src/dns-challenge-schema.json
>> +++ b/src/dns-challenge-schema.json
>> @@ -211,7 +211,24 @@
>> },
>> "kas" : {},
>> "kinghost" : {},
>> - "knot" : {},
>> + "knot" : {
>> + "fields" : {
>> + "KNOT_SERVER" : {
>> + "description" : "Hostname of the RFC 2136 compatible nameserver",
>> + "type" : "string"
>> + },
>> + "KNOT_KEY" : {
>> + "description" : "TSIG key (format alg:name:key)",
>> + "type" : "string"
>> + },
>> + "KNOT_ZONE" : {
>
> I did not find this variable being used anywhere in the acme.sh knot plugin[0], there's
> only KNOT_SERVER and KNOT_KEY being accessed, so what's up with that one?
>
> [1] https://git.proxmox.com/?p=mirror_acme.sh.git;a=blob;f=dnsapi/dns_knot.sh;hb=3.0.1
Hm, the parameter is documented but not used in code:
https://github.com/acmesh-official/acme.sh/wiki/dnsapi#19-use-knot-knsupdate-dns-api-to-automatically-issue-cert
I sent an updated patch without it.
>> + "description" : "DNS zone name (optional)",
>> + "optional" : 1,
>> + "type" : "string"
>> + }
>> + },
>> + "name" : "Knot / knsupdate (RFC 2136)"
>> + },
>> "leaseweb" : {},
>> "lexicon" : {},
>> "linode" : {},
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2021-11-18 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 8:03 Jens Meißner
2021-11-17 16:27 ` Thomas Lamprecht
2021-11-18 8:50 ` Jens Meißner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b869de82-6c08-f650-3a5e-1b78d059f01c@b1-systems.de \
--to=meissner@b1-systems.de \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox