From: Mira Limbeck <m.limbeck@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve-manager v2 1/2] fix #4963: firewall: fix editing firewall rules using ips / cidrs
Date: Tue, 16 Jan 2024 15:52:03 +0100 [thread overview]
Message-ID: <b7f8a05c-2251-49bf-977f-bfc6e059b50b@proxmox.com> (raw)
In-Reply-To: <20240116143022.359921-1-s.hanreich@proxmox.com>
On 1/16/24 15:30, Stefan Hanreich wrote:
> fall back to using v.ref as value when we do not have an alias or ipset
> since scope and name are not set for ips / cidrs
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>
> Changes from v1:
> * Added fix for an additional bug causing changes to IPs not being
> picked up by the input panel
>
> www/manager6/form/IPRefSelector.js | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/www/manager6/form/IPRefSelector.js b/www/manager6/form/IPRefSelector.js
> index b50ac1e10..7e5eea63a 100644
> --- a/www/manager6/form/IPRefSelector.js
> +++ b/www/manager6/form/IPRefSelector.js
> @@ -37,8 +37,10 @@ Ext.define('PVE.form.IPRefSelector', {
> calculate: function(v) {
> if (v.type === 'alias') {
> return `${v.scope}/${v.name}`;
> - } else {
> + } else if (v.type === 'ipset') {
> return `+${v.scope}/${v.name}`;
> + } else {
> + return v.ref;
> }
> },
> },
lgtm, consider this:
Reviewed-by: Mira Limbeck <m.limbeck@proxmox.com>
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
next prev parent reply other threads:[~2024-01-16 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 14:30 Stefan Hanreich
2024-01-16 14:30 ` [pve-devel] [PATCH pve-manager v2 2/2] firewall: properly detect changes when ip / cidr is used in rule Stefan Hanreich
2024-01-16 14:57 ` Mira Limbeck
2024-01-16 14:52 ` Mira Limbeck [this message]
2024-02-14 11:39 ` [pve-devel] [PATCH pve-manager v2 1/2] fix #4963: firewall: fix editing firewall rules using ips / cidrs Filip Schauer
2024-04-12 8:34 ` Stefan Hanreich
2024-04-12 12:21 ` [pve-devel] applied-series: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7f8a05c-2251-49bf-977f-bfc6e059b50b@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox