From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] tui: fix changing between non-LVM and LVM filesystem in bootdisk chooser
Date: Fri, 17 Nov 2023 13:20:31 +0100 [thread overview]
Message-ID: <b7d2b0e2-d01a-4b8d-babe-3dc68e8df8f6@proxmox.com> (raw)
In-Reply-To: <20231117121319.482709-1-c.heiss@proxmox.com>
Am 17/11/2023 um 13:12 schrieb Christoph Heiss:
> Happens due to a force-unwrap() under the false assumption that the
> disk for LVM configurations always exists when switching to a LVM
> filesystem.
> This fails spectacularly with a panic when switching from e.g. Btrfs to
> ext4 in the filesystem chooser.
>
> Fixes: eda9fa0 ("fix #4856: tui: bootdisk: use correct defaults in advanced dialog")
> Reported-by: Christian Ebner <c.ebner@proxmox.com>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> proxmox-tui-installer/src/views/bootdisk.rs | 29 +++++++++++----------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
>
applied, thanks!
Could be nice to get the installer code unwrap free in the future, or
at least add a safety comment for each case (but preferably the former)
next prev parent reply other threads:[~2023-11-17 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 12:12 [pve-devel] " Christoph Heiss
2023-11-17 12:20 ` Thomas Lamprecht [this message]
2023-11-17 12:33 ` [pve-devel] applied: " Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7d2b0e2-d01a-4b8d-babe-3dc68e8df8f6@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox