Re: [pve-devel] [PATCH manager 6/9] report: switch `dmidecode` to quiet to omit almost never needed info

[Alexander Zeidler <a.zeidler@proxmox.com>]

On Mon, 2024-03-25 at 09:20 +0100, Thomas Lamprecht wrote:
> On 22/03/2024 14:59, Alexander Zeidler wrote:
> > like on this system:
> > 
> >  # dmidecode -t bios
> >  # dmidecode 3.4
> >  Getting SMBIOS data from sysfs.
> >  SMBIOS 3.0.0 present.
> > 
> >  Handle 0x0000, DMI type 0, 24 bytes
> > 
> >  Handle 0x005C, DMI type 13, 22 bytes
> 
> 
> The manual page here states that this option also hides other entries:
> 
> > Unknown, inactive and OEM-specific entries are not displayed. Meta-data and handle references are hidden.
> 
> So especially on newer HW this might contain some actual info beyond
> the SMBIOS version/metadata that gets hidden.
> 
> I mean, I have no hard feelings here, but I'm wondering if it's really
> worth hiding that info if it can include potential relevant stuff.

Sounds reasonable, thank you! Will drop this patch.

> 
> > 
> > Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> > ---
> >  PVE/Report.pm | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/PVE/Report.pm b/PVE/Report.pm
> > index 505629c7..3a81bdb2 100644
> > --- a/PVE/Report.pm
> > +++ b/PVE/Report.pm
> > @@ -104,7 +104,7 @@ my $init_report_cmds = sub {
> >  	hardware => {
> >  	    order => 70,
> >  	    cmds => [
> > -		'dmidecode -t bios',
> > +		'dmidecode -t bios -q',
> >  		'lscpu',
> >  		'lspci -nnk',
> >  	    ],
>