public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] superseded: [PATCH proxmox{-ve-rs, -firewall} v2 0/4] Fix ipfilters in proxmox-firewall
Date: Wed, 1 Oct 2025 18:30:16 +0200	[thread overview]
Message-ID: <b725b54d-e21c-46ba-92b4-d637a8c51c6a@proxmox.com> (raw)
In-Reply-To: <20250925122142.228719-1-s.hanreich@proxmox.com>

https://lore.proxmox.com/pve-devel/20251001162818.320717-1-s.hanreich@proxmox.com/T/#m96f63f1eaf21149b7140dec51b82bf3d97942c97

On 9/25/25 2:21 PM, Stefan Hanreich wrote:
> This patch series addresses two issues with ipfilters:
> 
> * containers would have the wrong CIDR inserted into the auto-generated ipfilter
>   ipsets
> * The nomatch logic isn't working correctly, due to wrong inversion of logic,
>   leading to ipfilters not working at all
> 
> Including the rustfmt patch here as well, instead of separately since we touch
> some of the imports that get changed there - leading to conflicts on applying
> otherwise.
> 
> Changes from v1:
> * properly regenerate test-output with the proxmox-ve-rs patch applied
> * improve documentation of handle_set and handle_ipfilter
> 
> proxmox-ve-rs:
> 
> Stefan Hanreich (1):
>   config: guest: store network devices in BTreeMap
> 
>  proxmox-ve-config/src/guest/vm.rs | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> 
> proxmox-firewall:
> 
> Stefan Hanreich (3):
>   run rustfmt
>   ipfilter: fix wrong entries for containers
>   fix #6336: fix ipfilter matching logic
> 
>  proxmox-firewall/src/config.rs                |   6 +-
>  proxmox-firewall/src/firewall.rs              |  16 +-
>  proxmox-firewall/src/object.rs                |   6 +-
>  proxmox-firewall/src/rule.rs                  | 161 +++++--
>  proxmox-firewall/tests/input/100.conf         |   1 +
>  .../integration_tests__firewall.snap          | 416 ++++++++++++++++++
>  6 files changed, 565 insertions(+), 41 deletions(-)
> 
> 
> Summary over all repositories:
>   7 files changed, 569 insertions(+), 45 deletions(-)
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-10-01 16:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25 12:21 [pve-devel] " Stefan Hanreich
2025-09-25 12:21 ` [pve-devel] [PATCH proxmox-ve-rs v2 1/1] config: guest: store network devices in BTreeMap Stefan Hanreich
2025-10-01  7:23   ` Hannes Laimer
2025-10-01  8:17     ` Stefan Hanreich
2025-09-25 12:21 ` [pve-devel] [PATCH proxmox-firewall v2 1/3] run rustfmt Stefan Hanreich
2025-09-25 12:21 ` [pve-devel] [PATCH proxmox-firewall v2 2/3] ipfilter: fix wrong entries for containers Stefan Hanreich
2025-09-25 12:21 ` [pve-devel] [PATCH proxmox-firewall v2 3/3] fix #6336: fix ipfilter matching logic Stefan Hanreich
2025-10-01  7:31   ` Hannes Laimer
2025-10-01  8:11     ` Stefan Hanreich
2025-10-01 16:30 ` Stefan Hanreich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b725b54d-e21c-46ba-92b4-d637a8c51c6a@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal