public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] fix #2336: ui: adjust message for bulk start/stop/migrate
@ 2023-11-07 11:38 Folke Gleumes
  2023-11-07 15:55 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Folke Gleumes @ 2023-11-07 11:38 UTC (permalink / raw)
  To: pve-devel

The message in the Task Log has been 'Start/Stop/Migrate all...',
which is misleading since not everything might be affected by bulk actions.
This also affects the messages send at a nodes startup and shutdown, but
since this just affects a subgroup of VMs/Containers (those who are
onboot=1) the new wording still applies better than the previous.

Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
---

After applying, please run make update on proxmox-i18n so updated translations
can be submitted.

 www/manager6/Utils.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 8f46c07e..be30393e 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1967,7 +1967,7 @@ Ext.define('PVE.Utils', {
 	    lvmremove: ['Volume Group', gettext('Remove')],
 	    lvmthincreate: [gettext('LVM-Thin Storage'), gettext('Create')],
 	    lvmthinremove: ['Thinpool', gettext('Remove')],
-	    migrateall: ['', gettext('Migrate all VMs and Containers')],
+	    migrateall: ['', gettext('Bulk migrate VMs and Containers')],
 	    'move_volume': ['CT', gettext('Move Volume')],
 	    'pbs-download': ['VM/CT', gettext('File Restore Download')],
 	    pull_file: ['CT', gettext('Pull file')],
@@ -1994,8 +1994,8 @@ Ext.define('PVE.Utils', {
 	    resize: ['VM/CT', gettext('Resize')],
 	    spiceproxy: ['VM/CT', gettext('Console') + ' (Spice)'],
 	    spiceshell: ['', gettext('Shell') + ' (Spice)'],
-	    startall: ['', gettext('Start all VMs and Containers')],
-	    stopall: ['', gettext('Stop all VMs and Containers')],
+	    startall: ['', gettext('Bulk start VMs and Containers')],
+	    stopall: ['', gettext('Bulk shutdown VMs and Containers')],
 	    unknownimgdel: ['', gettext('Destroy image from unknown guest')],
 	    wipedisk: ['Device', gettext('Wipe Disk')],
 	    vncproxy: ['VM/CT', gettext('Console')],
-- 
2.39.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] fix #2336: ui: adjust message for bulk start/stop/migrate
  2023-11-07 11:38 [pve-devel] [PATCH manager] fix #2336: ui: adjust message for bulk start/stop/migrate Folke Gleumes
@ 2023-11-07 15:55 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-11-07 15:55 UTC (permalink / raw)
  To: Proxmox VE development discussion, Folke Gleumes

Am 07/11/2023 um 12:38 schrieb Folke Gleumes:
> The message in the Task Log has been 'Start/Stop/Migrate all...',
> which is misleading since not everything might be affected by bulk actions.
> This also affects the messages send at a nodes startup and shutdown, but
> since this just affects a subgroup of VMs/Containers (those who are
> onboot=1) the new wording still applies better than the previous.
> 
> Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
> ---
> 
> After applying, please run make update on proxmox-i18n so updated translations
> can be submitted.
> 
>  www/manager6/Utils.js | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
>

applied, and I already updated i18n too, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-07 15:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-07 11:38 [pve-devel] [PATCH manager] fix #2336: ui: adjust message for bulk start/stop/migrate Folke Gleumes
2023-11-07 15:55 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal