public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 many 00/11] notifications: add SMTP endpoint
Date: Thu, 9 Nov 2023 13:34:07 +0100	[thread overview]
Message-ID: <b63e7939-23d7-46f8-a9e5-c6d53a0f1789@proxmox.com> (raw)
In-Reply-To: <131553887.2107.1699532181548@webmail.proxmox.com>

On 11/9/23 13:16, Dietmar Maurer wrote:
>> On 11/8/23 16:52, Dietmar Maurer wrote:
>>>> This patch series adds support for a new notification endpoint type,
>>>> smtp. As the name suggests, this new endpoint allows PVE to talk
>>>> to SMTP server directly, without using the system's MTA (postfix).
>>>
>>> Isn't this totally unreliable? What if the server responds with a
>>> temporary error code? (An MTA retries several times).
>>
>> The notification system has no mechanism yet for queuing/retries,
>> so yes, at the moment a SMTP endpoint would indeed be less reliable than
>> a 'sendmail' endpoint. I'm not sure though if I would call it
>> 'totally unreliable'.
> 
> This kind of notification system is quite popular for (PHP) web-sites contact
> form. I have seen many over-simplified implementation overs the years,
> and yes, it is totally unreliable.
> 
> That is why we always used an MTA to deliver mails...

I see. What would be your suggestion? To not have such a plugin at all?
I implemented this because it was explicitly mentioned by Thomas in the 
tracking bugzilla issue for an overhauled notification system [1].
Not having to configure Postfix if one wants to use an external
SMTP relay seems to be add quite a lot of value to the user (e.g. 
judging from [2] and [3])
As a compromise, maybe we could just add a note to the docs
that discusses the reliability aspects of 'sendmail' vs 'smtp'
endpoints?

[1] https://bugzilla.proxmox.com/show_bug.cgi?id=4156
[2] https://bugzilla.proxmox.com/show_bug.cgi?id=2965
[3] 
https://forum.proxmox.com/threads/get-postfix-to-send-notifications-email-externally.59940/

-- 
- Lukas




  reply	other threads:[~2023-11-09 12:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08 15:39 Lukas Wagner
2023-11-08 15:39 ` [pve-devel] [PATCH v4 debcargo-conf 01/11] cherry-pick chumsky 0.9.2 from debian unstable Lukas Wagner
2023-11-08 15:39 ` [pve-devel] [PATCH v4 debcargo-conf 02/11] update lettre to 0.11.1 Lukas Wagner
2023-11-08 15:39 ` [pve-devel] [PATCH v4 proxmox 03/11] sys: email: add `forward` Lukas Wagner
2023-11-08 15:39 ` [pve-devel] [PATCH v4 proxmox 04/11] notify: add mechanisms for email message forwarding Lukas Wagner
2023-11-08 15:39 ` [pve-devel] [PATCH v4 proxmox 05/11] notify: add 'smtp' endpoint Lukas Wagner
2023-11-08 15:40 ` [pve-devel] [PATCH v4 proxmox 06/11] notify: add api for smtp endpoints Lukas Wagner
2023-11-08 15:40 ` [pve-devel] [PATCH v4 proxmox-perl-rs 07/11] notify: add bindings for smtp API calls Lukas Wagner
2023-11-08 15:40 ` [pve-devel] [PATCH v4 pve-manager 08/11] notify: add API routes for smtp endpoints Lukas Wagner
2023-11-08 15:40 ` [pve-devel] [PATCH v4 proxmox-widget-toolkit 09/11] panel: notification: add gui for SMTP endpoints Lukas Wagner
2023-11-08 15:40 ` [pve-devel] [PATCH v4 pve-docs 10/11] notifications: document " Lukas Wagner
2023-11-08 15:40 ` [pve-devel] [PATCH v4 pve-docs 11/11] notifications: document 'comment' option for targets/matchers Lukas Wagner
2023-11-08 15:52 ` [pve-devel] [PATCH v4 many 00/11] notifications: add SMTP endpoint Dietmar Maurer
2023-11-09 10:23   ` Lukas Wagner
2023-11-09 12:16     ` Dietmar Maurer
2023-11-09 12:34       ` Lukas Wagner [this message]
2023-11-09 13:10         ` Thomas Lamprecht
2023-11-09 15:35           ` Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b63e7939-23d7-46f8-a9e5-c6d53a0f1789@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=dietmar@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal