From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Matthias Heiserer <m.heiserer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 qemu-server 2/2] fix #3890: warn in GUI for unlikely iothread config
Date: Fri, 10 Jun 2022 11:20:22 +0200 [thread overview]
Message-ID: <b6065640-953e-0a0f-ebfb-3ed71e974401@proxmox.com> (raw)
In-Reply-To: <20220527114810.510501-4-m.heiserer@proxmox.com>
Am 27.05.22 um 13:48 schrieb Matthias Heiserer:
> Previously, only a plaintext line in the task log showed something was off.
> Now, the GUI will show it as a warning.
>
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index e9aa248..2536d73 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -41,6 +41,7 @@ use PVE::Storage;
> use PVE::SysFSTools;
> use PVE::Systemd;
> use PVE::Tools qw(run_command file_read_firstline file_get_contents dir_glob_foreach get_host_arch $IPV6RE);
> +use PVE::RESTEnvironment qw(log_warn);
Nit: not ordered alphabetically
next prev parent reply other threads:[~2022-06-10 9:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 11:48 [pve-devel] [PATCH v4 manager 1/3] fix typo Matthias Heiserer
2022-05-27 11:48 ` [pve-devel] [PATCH v4 qemu-server 1/2] bump pve-common Matthias Heiserer
2022-05-28 7:09 ` Thomas Lamprecht
2022-05-27 11:48 ` [pve-devel] [PATCH v4 manager] HDEdit: check iothread by default and move it from advanced section Matthias Heiserer
2022-06-10 9:20 ` Fabian Ebner
2022-06-13 9:59 ` Matthias Heiserer
2022-05-27 11:48 ` [pve-devel] [PATCH v4 qemu-server 2/2] fix #3890: warn in GUI for unlikely iothread config Matthias Heiserer
2022-06-10 9:20 ` Fabian Ebner [this message]
2022-05-27 11:48 ` [pve-devel] [PATCH v4 manager 3/3] OS defaults: use SCSI single as default controller Matthias Heiserer
2022-06-10 9:20 ` Fabian Ebner
2022-05-28 7:19 ` [pve-devel] applied: [PATCH v4 manager 1/3] fix typo Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6065640-953e-0a0f-ebfb-3ed71e974401@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox