From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexander Zeidler <a.zeidler@proxmox.com>
Subject: [pve-devel] applied: [PATCH docs v2 1/6] ceph: add anchors for use in troubleshooting section
Date: Mon, 24 Mar 2025 17:42:27 +0100 [thread overview]
Message-ID: <b5662161-9f81-4a67-b3de-a1246f1b272c@proxmox.com> (raw)
In-Reply-To: <20250205100850.3-1-a.zeidler@proxmox.com>
On 2025-02-05 11:08, Alexander Zeidler wrote:
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
> v2:
> * add two missing anchors to be usable via xref
>
> pve-disk-health-monitoring.adoc | 1 +
> pveceph.adoc | 8 ++++++++
> pvecm.adoc | 1 +
> 3 files changed, 10 insertions(+)
>
>
thanks for the work to extend the docs!
applied with some changes and follow-ups:
* we do not want to break the anchor to the ceph recommendations. This
anchor is in use to redirect customers and users to ceph requirements.
Yes it is ugly, but we cannot change it so we keep it.
* I do not think that inline CLI commands are a good idea as they are
make the paragraph messy and harder to read and are hard to copy&paste.
Therefore, I rephrased those parts to have them in their own code blocks.
* rephrased the Destroy OSD section, mainly to also place the CLI
commands into code blocks and a few other things you can see in the
follow up commit.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-03-24 16:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 10:08 [pve-devel] " Alexander Zeidler
2025-02-05 10:08 ` [pve-devel] [PATCH docs v2 2/6] ceph: correct heading capitalization Alexander Zeidler
2025-02-05 10:08 ` [pve-devel] [PATCH docs v2 3/6] ceph: troubleshooting: revise and add frequently needed information Alexander Zeidler
2025-02-05 10:08 ` [pve-devel] [PATCH docs v2 4/6] ceph: osd: revise and expand the section "Destroy OSDs" Alexander Zeidler
2025-02-05 10:08 ` [pve-devel] [PATCH docs v2 5/6] ceph: maintenance: revise and expand section "Replace OSDs" Alexander Zeidler
2025-02-05 10:08 ` [pve-devel] [PATCH docs v2 6/6] pvecm: remove node: mention Ceph and its steps for safe removal Alexander Zeidler
2025-02-05 14:20 ` [pve-devel] [PATCH docs v2 1/6] ceph: add anchors for use in troubleshooting section Max Carrara
2025-03-24 16:42 ` Aaron Lauterer [this message]
2025-03-26 10:20 ` [pve-devel] applied: " Max Carrara
2025-03-26 13:13 ` Aaron Lauterer
2025-03-26 13:36 ` Max Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5662161-9f81-4a67-b3de-a1246f1b272c@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal