From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 common 0/1] fix #1454: ARC in Node Summary
Date: Tue, 28 Mar 2023 18:08:36 +0200 [thread overview]
Message-ID: <b4cfb9a6-3d91-2f51-7cfe-2d2f6b77239c@proxmox.com> (raw)
In-Reply-To: <20230328124929.161040-1-m.heiserer@proxmox.com>
Tested-by: Max Carrara <m.carrara@proxmox.com>
Reviewed-by: Max Carrara <m.carrara@proxmox.com>
Looks pretty good; I'm not 100% sure about the ARC bar's dark theme
colour, but I like the light theme's a lot. Maybe somebody else could
chime in with other suggestions.
I also checked again whether the ARC bar remains visible if the RAM
approaches critical levels (and consequently turns yellow/red), as we
already had done off-list, just in case.
prev parent reply other threads:[~2023-03-28 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 12:49 Matthias Heiserer
2023-03-28 12:49 ` [pve-devel] [PATCH v2 common 1/1] fix #1454: meminfo: also return arcsize Matthias Heiserer
2023-04-13 10:26 ` Thomas Lamprecht
2023-03-28 12:49 ` [pve-devel] [PATCH v2 manager 1/2] fix #1454: node/status: return arc size Matthias Heiserer
2023-03-28 12:49 ` [pve-devel] [PATCH v2 widget-toolkit] fix #1454: InfoWidget for Memory Matthias Heiserer
2023-04-13 15:48 ` Stefan Sterz
2023-03-28 12:49 ` [pve-devel] [PATCH v2 manager 2/2] fix #1454: ui: node summary: show arc alongside RAM Matthias Heiserer
2023-03-28 16:08 ` Max Carrara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4cfb9a6-3d91-2f51-7cfe-2d2f6b77239c@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox