From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH docs/widget-toolkit/manager v3] implement tagview
Date: Sun, 10 Nov 2024 12:22:18 +0100 [thread overview]
Message-ID: <b496924d-0182-4535-9013-a24add1d7a18@proxmox.com> (raw)
In-Reply-To: <20241107112521.2075598-1-d.csapak@proxmox.com>
Am 07.11.24 um 12:25 schrieb Dominik Csapak:
> this adds a 'tagview' to the web ui, organizing guests by their tags
> (for details see the pve-manager patch)
>
> I'm not super happy all in all with how much special casing must be
> done, but i could not (yet?) figure out a better way.
>
> changes from v2:
> * rebased on master (tooltip generation changed so adapted to that)
> * implemented fionas feedback, so selection should stay even when tags
> are removed or the selection is changed from the tag view
>
> changes from v1:
> * rebase on master
> * adapt to recent tooltip changes
> * add a comment to TagConfig class to better explain what it does
>
> pve-docs:
>
> Dominik Csapak (1):
> gui: add anchor for tags chapter
>
> pve-gui.adoc | 1 +
> 1 file changed, 1 insertion(+)
>
> proxmox-widget-toolkit:
>
> Dominik Csapak (1):
> css: add some conditions to the tag classes for the tag view
>
> src/css/ext6-pmx.css | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
> pve-manager:
>
> Dominik Csapak (1):
> ui: implement 'Tag View' for the resource tree
>
> www/manager6/Makefile | 1 +
> www/manager6/Workspace.js | 4 +-
> www/manager6/form/ViewSelector.js | 28 +++++++++++
> www/manager6/grid/ResourceGrid.js | 2 +-
> www/manager6/panel/TagConfig.js | 6 +++
> www/manager6/tree/ResourceTree.js | 81 ++++++++++++++++++++++++++++---
> 6 files changed, 113 insertions(+), 9 deletions(-)
> create mode 100644 www/manager6/panel/TagConfig.js
>
applied, thanks!
What would be nice to have is to optionally show also nodes and storage entries
for the tag and pool views, so that these views can be used as only one to fully
manage all resources. This probably should even become an opt-out setting.
semi-related, allowing one to group (shared) storages with the same name might
also be great to make the resource tree clearer and quicker to find things if
one has more than a few nodes/storages. I.e., I'd join the list of nodes in the
tree where the current node name is and add a node selector filtered to the
available nodes in the storage view to allow selecting another node, that way
we might even group storages that are distinct on every node, or leave that up
to select, i.e.:
Group Storages: [ Default (No) ]
| No |
| Shared Only |
| All |
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-10 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 11:25 [pve-devel] " Dominik Csapak
2024-11-07 11:25 ` [pve-devel] [PATCH docs v3 1/1] gui: add anchor for tags chapter Dominik Csapak
2024-11-07 11:25 ` [pve-devel] [PATCH widget-toolkit v3 1/1] css: add some conditions to the tag classes for the tag view Dominik Csapak
2024-11-07 11:25 ` [pve-devel] [PATCH manager v3 1/1] ui: implement 'Tag View' for the resource tree Dominik Csapak
2024-11-07 13:52 ` [pve-devel] [PATCH docs/widget-toolkit/manager v3] implement tagview Aaron Lauterer
2024-11-07 14:16 ` Dominik Csapak
2024-11-07 14:20 ` Aaron Lauterer
2024-11-08 9:44 ` Daniel Herzig
2024-11-10 11:22 ` Thomas Lamprecht [this message]
2024-11-11 13:58 ` [pve-devel] applied-series: " Dominik Csapak
2024-11-11 14:26 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b496924d-0182-4535-9013-a24add1d7a18@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox