From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [pbs-devel] [PATCH manager/proxmox{-widget-toolkit, -backup} v2 0/4] replace Proxmox logo with SVG version
Date: Mon, 4 Aug 2025 11:27:11 +0200 [thread overview]
Message-ID: <b42f569c-139d-4fd1-ae37-9b4253e808c4@proxmox.com> (raw)
In-Reply-To: <20250804090228.192088-1-l.wagner@proxmox.com>
Looks crisp and works as intended now. The logos colors are switched
correctly also if the preferred color scheme is set to dark in the browser.
And the extra padding to the right of the logo in PVE looks good to me.
One thing came to mind: this should maybe also be included for the PMG
ui were the old component is still in use? But that can be a followup.
In the long run we should also replace some of the icons which do not
render well, e.g. the edit dashboard settings gear icon in PBS.
Other than that, consider:
Tested-by: Christian Ebner <c.ebner@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-04 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 9:02 [pve-devel] " Lukas Wagner
2025-08-04 9:02 ` [pve-devel] [PATCH proxmox-widget-toolkit v2 1/1] add Proxmox logo as SVG Lukas Wagner
2025-08-04 9:02 ` [pve-devel] [PATCH proxmox-backup v2 1/1] ui: replace Proxmox logo with SVG version Lukas Wagner
2025-08-04 9:02 ` [pve-devel] [PATCH manager v2 1/2] " Lukas Wagner
2025-08-04 9:02 ` [pve-devel] [PATCH manager v2 2/2] ui: add 5px of padding between Proxmox logo and product name Lukas Wagner
2025-08-04 9:27 ` Christian Ebner [this message]
2025-08-04 9:31 ` [pve-devel] [pbs-devel] [PATCH manager/proxmox{-widget-toolkit, -backup} v2 0/4] replace Proxmox logo with SVG version Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b42f569c-139d-4fd1-ae37-9b4253e808c4@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox