From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: [pve-devel] partially-applied: [PATCH manager v2 1/2] ui: dc: backup: improve UX for the different 'notification-mode's
Date: Sun, 21 Apr 2024 13:50:25 +0200 [thread overview]
Message-ID: <b3e10eb1-2def-46a0-805e-7b983d75f14b@proxmox.com> (raw)
In-Reply-To: <20240415095102.2566187-1-l.wagner@proxmox.com>
Am 15/04/2024 um 11:51 schrieb Lukas Wagner:
> - Switch order of 'mailto' and 'mailnotification' field
> - When mode is 'auto', disable 'mailtnotification' field
> - When mode is 'auto' and 'mailto' is empty, show
> hint that the notification system will be used
If one starts making lists about different things a commit does, it might
be good to evaluate if it should be split into multiple commits..
I dropped the hint part, this is IMO really not better than nothing in
its current state, as besides being quite flashy it doesn't really
explains what's going on.
Now with the advanced tab we could move the extra fields in there, add a
extended explanation potentially even providing a link to the local docs'
notification section (or wherever this is explained in detail in the
docs).
As compromise for now I'd accept that text without the pmx-hint class and
a link to the docs added in the text (could also be just a question mark
icon at the end, i.e. the help button without a text label).
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-21 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 9:51 [pve-devel] " Lukas Wagner
2024-04-15 9:51 ` [pve-devel] [PATCH manager v2 2/2] ui: one-off backup: show hint if notification-system is used Lukas Wagner
2024-04-21 11:50 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3e10eb1-2def-46a0-805e-7b983d75f14b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox