From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2] API2/Ceph: fix createpools 'add_storages' parameter
Date: Tue, 24 Nov 2020 15:47:22 +0100 [thread overview]
Message-ID: <b3b9540e-1552-8dd4-7e62-34f9bedd8fa8@proxmox.com> (raw)
In-Reply-To: <20201124143255.27479-1-d.csapak@proxmox.com>
On 24.11.20 15:32, Dominik Csapak wrote:
> by deleteing it from $ceph_param we deleted it also from
> $param since it was only a reference
>
> fix it by extracting it beforehand
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * also use $add_storages in permission check/pool name check
>
> PVE/API2/Ceph.pm | 29 +++++++++++++----------------
> 1 file changed, 13 insertions(+), 16 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-11-24 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 14:32 [pve-devel] " Dominik Csapak
2020-11-24 14:47 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b9540e-1552-8dd4-7e62-34f9bedd8fa8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox