Re: [PATCH qemu-server 3/3] removed some unnecessary undef checks.

[Fiona Ebner <f.ebner@proxmox.com>]

Am 05.08.26 um 10:24 AM schrieb Elias Huhsovitz:
> Summary
> -------
> * classify_drive_file() and drive_has_absolute_path() are not prepared
>   to handle undef values, and therefore removing the undef checks causes
>   a change in behaviour
> 
> * commit message should be imperative, e.g., "remove some unnecessary
> undef checks"
> 
> On Mon Aug 3, 2026 at 2:12 PM CEST, Thomas Ellmenreich wrote:
>> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
>> ---
>>  src/PVE/QemuServer.pm | 12 ++++--------
>>  1 file changed, 4 insertions(+), 8 deletions(-)
>>
>> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
>> index 0e998cbe..3141b298 100644
>> --- a/src/PVE/QemuServer.pm
>> +++ b/src/PVE/QemuServer.pm
>> @@ -1818,11 +1818,10 @@ sub destroy_vm {
>>              { include_unused => 1 },
>>              sub {
>>                  my ($ds, $drive) = @_;
>> -                return if drive_is_cdrom($drive);
>>  
>> -                my $volid = $drive->{file};
>> -                return if !$volid || drive_has_absolute_path($drive);
> 
> I think this might result in an edge case where $drive->{file} can be undef,
> causing the underlying function classify_drive_file() that drive_has_absolute_path()
> calls, to emit a warning.

No, because the foreach_volume_full() function parses the drive string
and skips without calling the subroutine if parsing fails. If parsing
succeeds, $drive->{file} is populated. Of course the rationale for why
removing the checks is justified should be stated in the commit message.