public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage 1/2] don't bail on whitespaces in backing devices
Date: Tue, 30 Apr 2024 11:45:05 +0200	[thread overview]
Message-ID: <b37948f5-a321-456c-88a1-dacdb8e3d503@proxmox.com> (raw)
In-Reply-To: <21017c63-9c3c-48ea-8152-df5c66fa1a0c@proxmox.com>

On 4/30/24 11:13, Fiona Ebner wrote:
> Am 30.04.24 um 10:38 schrieb Wolfgang Bumiller:
>> - technically users could add a disk with a "bad" parent to a storage
>>    *manually*, but given the list_images mentioned above, I'd argue the
>>    situation isn't really getting worse, as values that *do* match `\S+`
>>    don't necessarily match the regexes used *later* on the parent
>>    *anyway*...
>>
> 
> CC Dominik
> 
> Thinking in the context of uploading OVAs (or uploading disk images), I
> guess we need a check against arbitrary backing file paths in uploaded
> qcow2/vmdk images (or do we already have that)?
> 

good point, we currently don't, but it shouldn't be hard to add that check
before importing/after uploading... i'll look into that


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2024-04-30  9:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30  7:53 Wolfgang Bumiller
2024-04-30  7:53 ` [pve-devel] [PATCH storage 2/2] fixup error messages in file_size_info Wolfgang Bumiller
2024-04-30  8:14 ` [pve-devel] [PATCH storage 1/2] don't bail on whitespaces in backing devices Fiona Ebner
2024-04-30  8:38   ` Wolfgang Bumiller
2024-04-30  9:13     ` Fiona Ebner
2024-04-30  9:23       ` Wolfgang Bumiller
2024-04-30  9:45       ` Dominik Csapak [this message]
2024-04-30  8:22 ` [pve-devel] applied-series: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b37948f5-a321-456c-88a1-dacdb8e3d503@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal