From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH 1/2] config: allow hypens and dots in config keys
Date: Tue, 22 Oct 2024 08:45:15 +0200 [thread overview]
Message-ID: <b302fa4a-a0e1-4e5e-8cb1-f54e56dc566c@proxmox.com> (raw)
In-Reply-To: <20240924143502.361901-1-m.sandoval@proxmox.com>
s/hypens/hyphens/
Am 24/09/2024 um 16:35 schrieb Maximiliano Sandoval:
> The first character still has to be a letter.
Such a patch really must have more rationale for why each character
is required, e.g. for hyphens it would be allowing using kebab-case
like we use for (most) new schema properties, might be obvious to
you, but it hasn't to be obvious for every dev or (potential)
contributor. Dot on the other hand isnt' obvious to me, do we use
that anywhere, why should it be allowed for properties if we want
to switch everything to kebab-case in the long term? As this would
only allow adding further inconsistency?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-10-22 6:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 14:35 Maximiliano Sandoval
2024-09-24 14:35 ` [pve-devel] [RFC PATCH 2/2] config: add systemd credentials support Maximiliano Sandoval
2024-10-22 8:29 ` Fabian Grünbichler
2024-10-21 12:19 ` [pve-devel] [RFC PATCH 1/2] config: allow hypens and dots in config keys Fiona Ebner
2024-10-22 6:45 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b302fa4a-a0e1-4e5e-8cb1-f54e56dc566c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox