From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pve-devel] applied: [[PATCH kernel]] fix 5683: netfs: reset subreq iov iter before tail clean
Date: Wed, 23 Oct 2024 15:52:29 +0200 [thread overview]
Message-ID: <b2c39d43-daac-4ed3-99fd-db56588ccf7a@proxmox.com> (raw)
In-Reply-To: <20241002143624.1260363-1-c.ebner@proxmox.com>
Am 02/10/2024 um 16:36 schrieb Christian Ebner:
> Fixes rare read corruption issues using the in kernel ceph client.
>
> On incomplete read requests, the clean tail flag should make sure to
> zero fill the remaining bytes for the subrequest.
> If the iov iterator is not at the correct position, this can however
> zero fill downloaded data, corrupting the read content.
>
> Link to issue:
> https://bugzilla.proxmox.com/show_bug.cgi?id=5683
>
> Link to upstream issue:
> https://bugzilla.kernel.org/show_bug.cgi?id=219237
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> This fixes the read corruption issue with my local reproducer.
>
> Providing a patched kernel to users affected by the issue for testing
> would be probably the best way to verify the fix.
>
> Also, I reached out once again to the kernel developers asking if
> this fix is a valid approach, hoping this can be included in current
> stable (as the patch does fix the issue also when applied on 6.11.1).
>
> ...et-subreq-iov-iter-before-tail-clean.patch | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 patches/kernel/0021-netfs-reset-subreq-iov-iter-before-tail-clean.patch
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-10-23 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 14:36 [pve-devel] " Christian Ebner
2024-10-22 12:50 ` Fiona Ebner
2024-10-22 16:06 ` Christian Ebner
2024-10-22 13:57 ` Thomas Lamprecht
2024-10-22 15:46 ` Christian Ebner
2024-10-23 8:28 ` Thomas Lamprecht
2024-10-23 8:51 ` Christian Ebner
2024-10-27 11:48 ` Christian Ebner
2024-10-23 13:52 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2c39d43-daac-4ed3-99fd-db56588ccf7a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox