From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH v4 qemu-server 5/12] migration: add target_storage_check_available
Date: Fri, 16 Jun 2023 15:11:04 +0200 [thread overview]
Message-ID: <b2bc1f4a-8625-2c5c-4202-f6bdaa60ca31@proxmox.com> (raw)
In-Reply-To: <20230616095708.1323621-6-a.lauterer@proxmox.com>
Am 16.06.23 um 11:57 schrieb Aaron Lauterer:
> We use this in a few places. By factoring it into its own function, we
> can avoid running slightly different checks in various places.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
applied this one, thanks!
Not too important right now, but could be improved further by turning it
into a function taking all required parameters rather than having it as
a method and also adapting QemuServer.pm's check_storage_availability()
to use it, but certainly a start as-is and improves readability.
next prev parent reply other threads:[~2023-06-16 13:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 9:56 [pve-devel] [PATCH v4 qemu-server, container, docs 0/12] migration: don't scan all storages, fail on aliases Aaron Lauterer
2023-06-16 9:56 ` [pve-devel] [PATCH v4 qemu-server 1/12] migration: only migrate disks used by the guest Aaron Lauterer
2023-06-16 12:16 ` Fiona Ebner
2023-06-16 9:56 ` [pve-devel] [PATCH v4 qemu-server 2/12] qemuserver: foreach_volid: include pending volumes Aaron Lauterer
2023-06-16 12:25 ` Fiona Ebner
2023-06-16 12:37 ` Thomas Lamprecht
2023-06-16 9:56 ` [pve-devel] [PATCH v4 qemu-server 3/12] qemuserver: foreach_volid: always include pending disks Aaron Lauterer
2023-06-16 9:57 ` [pve-devel] [PATCH v4 qemu-server 4/12] qemuserver: foreach_volid: test regular config last Aaron Lauterer
2023-06-16 12:40 ` Fiona Ebner
2023-06-16 14:36 ` Aaron Lauterer
2023-06-16 9:57 ` [pve-devel] [PATCH v4 qemu-server 5/12] migration: add target_storage_check_available Aaron Lauterer
2023-06-16 13:11 ` Fiona Ebner [this message]
2023-06-16 9:57 ` [pve-devel] [PATCH v4 qemu-server 6/12] migration: scan_local_volumes: adapt refs handling Aaron Lauterer
2023-06-16 9:57 ` [pve-devel] [PATCH v4 qemu-server 7/12] tests: add migration test for pending disk Aaron Lauterer
2023-06-16 9:57 ` [pve-devel] [PATCH v4 qemu-server 8/12] migration: fail when aliased volume is detected Aaron Lauterer
2023-06-16 9:57 ` [pve-devel] [PATCH v4 qemu-server 9/12] tests: add migration alias check Aaron Lauterer
2023-06-16 9:57 ` [pve-devel] [PATCH v4 container 10/12] migration: only migrate volumes used by the guest Aaron Lauterer
2023-06-16 13:58 ` Fiona Ebner
2023-06-16 9:57 ` [pve-devel] [PATCH v4 container 11/12] migration: fail when aliased volume is detected Aaron Lauterer
2023-06-16 9:57 ` [pve-devel] [PATCH v4 docs 12/12] storage: add hint to avoid storage aliasing Aaron Lauterer
2023-06-16 14:12 ` [pve-devel] [PATCH v4 qemu-server, container, docs 0/12] migration: don't scan all storages, fail on aliases Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2bc1f4a-8625-2c5c-4202-f6bdaa60ca31@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox