public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH installer v2 0/4] auto-install-assistant: allow specifying 'fetch-from' partition label
Date: Sun, 10 Nov 2024 19:23:03 +0100	[thread overview]
Message-ID: <b2684177-7532-4090-b087-30cd72901856@proxmox.com> (raw)
In-Reply-To: <20241108130537.1266472-1-c.heiss@proxmox.com>

Am 08.11.24 um 14:05 schrieb Christoph Heiss:
> This series allow specifying the partition label the
> `proxmox-fetch-answer` tool will search when trying to retrieve an
> answer file in the 'partition' fetch mode.
> 
> This has been requested by at least one user one user [0] and definitely
> makes sense, esp. for BMCs/IPMIs where one might not be able to control
> the partition label.
> 
> Patch #1 implements the new CLI parameter in the
> `proxmox-auto-install-assistant` tool, patch #4 then integrates it into
> the `proxmox-fetch-answer` itself. Patch #2 is just a small (but needed)
> refactor of the CLI parsing code.
> 
> Patch #3 implements also searching for the partition label in the exact
> case it was specified by the user. This is something I stumbled over
> while testing it - see the patch itself for some more information.
> 
> [0] https://forum.proxmox.com/threads/proxmox-ais-question-request.153043/post-695689
> 
> History
> =======
> v1: https://lore.proxmox.com/pve-devel/20241018115943.813243-1-c.heiss@proxmox.com/
> 
> Notable Changes v1 -> v2:
>  * addressed suggestions by Aaron 
>  * added Aaron's T-b & R-b tags, thanks!
>  * dropped useless "proxmox-ais" explanation from --prepare-iso
>    description
> 
> Diffstat
> ========
> 
> Christoph Heiss (4):
>   auto-install-assistant: add new parameter to specify partition label
>   fetch-answer: refactor cli argument parsing
>   fetch-answer: partition: also search for exact-matching partition
>     label
>   fetch-answer: use partition label from fetch config instead of
>     hardcoded
> 
>  proxmox-auto-install-assistant/src/main.rs    | 15 ++++-
>  proxmox-auto-installer/src/utils.rs           |  1 +
>  .../src/fetch_plugins/partition.rs            | 32 ++++++----
>  proxmox-fetch-answer/src/main.rs              | 58 ++++++++++++++-----
>  4 files changed, 80 insertions(+), 26 deletions(-)
> 


applied series, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2024-11-10 18:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08 13:05 [pve-devel] " Christoph Heiss
2024-11-08 13:05 ` [pve-devel] [PATCH installer v2 1/4] auto-install-assistant: add new parameter to specify " Christoph Heiss
2024-11-08 13:05 ` [pve-devel] [PATCH installer v2 2/4] fetch-answer: refactor cli argument parsing Christoph Heiss
2024-11-08 13:05 ` [pve-devel] [PATCH installer v2 3/4] fetch-answer: partition: also search for exact-matching partition label Christoph Heiss
2024-11-08 13:05 ` [pve-devel] [PATCH installer v2 4/4] fetch-answer: use partition label from fetch config instead of hardcoded Christoph Heiss
2024-11-10 18:23 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2684177-7532-4090-b087-30cd72901856@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal