public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dylan Whyte <d.whyte@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-installer] installer: minor language fixup
Date: Thu, 10 Dec 2020 20:09:14 +0100	[thread overview]
Message-ID: <b20c236d-ec0a-cfcd-7c56-d38314586022@proxmox.com> (raw)
In-Reply-To: <20201126092912.28245-1-d.whyte@proxmox.com>

On 26.11.20 10:29, Dylan Whyte wrote:
> just some nitpicky changes.
> 
> Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
> ---
>  html-common/tags    |  1 +
>  html-pbs/page1.htm  |  2 +-
>  html-pbs/tags       |  1 +
>  html-pve/page1.htm  |  8 ++++----
>  html-pve/passwd.htm | 10 +++++-----
>  html-pve/tags       |  1 +
>  6 files changed, 13 insertions(+), 10 deletions(-)
>  create mode 100644 html-common/tags
>  create mode 100644 html-pbs/tags
>  create mode 100644 html-pve/tags

what are those new "tags" files? from your IDE? They do not seem right to me.

> 
> diff --git a/html-common/tags b/html-common/tags
> new file mode 100644
> index 0000000..408de88
> --- /dev/null
> +++ b/html-common/tags
> @@ -0,0 +1 @@
> +!_TAG_FILE_SORTED	2	/0=unsorted, 1=sorted, 2=foldcase/
> diff --git a/html-pbs/page1.htm b/html-pbs/page1.htm
> index debfdf1..353f780 100644
> --- a/html-pbs/page1.htm
> +++ b/html-pbs/page1.htm
> @@ -30,7 +30,7 @@
>        <tbody><tr>
>          <td valign="top" width="30"><img src="plus.png"></td>
>          <td valign="top"><b>Please verify the installation target</b><br>
> -          The displayed hard disk is used for installation.
> +          The displayed hard disk will be used for the installation.
>            <br>Warning: All existing partitions and data will be lost.
>            <br><br>
>          </td>
> diff --git a/html-pbs/tags b/html-pbs/tags
> new file mode 100644
> index 0000000..408de88
> --- /dev/null
> +++ b/html-pbs/tags
> @@ -0,0 +1 @@
> +!_TAG_FILE_SORTED	2	/0=unsorted, 1=sorted, 2=foldcase/
> diff --git a/html-pve/page1.htm b/html-pve/page1.htm
> index d76cc8a..0ad0898 100644
> --- a/html-pve/page1.htm
> +++ b/html-pve/page1.htm
> @@ -17,10 +17,10 @@
>      <table>
>        <tbody><tr><td><b>The Proxmox Installer</b>
>  	automatically partitions your hard disk. It installs all required
> -	packages and finally makes the system bootable from hard disk.
> +	packages and makes the system bootable from the hard disk.
>  	All existing partitions and data will be lost.
>  	<br><br>
> -	Press the Next button to continue installation.
> +	Press the Next button to continue the installation.
>        </td></tr>
>      </tbody></table>
>    </p></td>
> @@ -30,7 +30,7 @@
>        <tbody><tr>
>  	<td valign="top" width="30"><img src="plus.png"></td>
>  	<td valign="top"><b>Please verify the installation target</b><br>
> -	  The displayed hard disk is used for installation.
> +	  The displayed hard disk will be used for the installation.
>  	  <br>Warning: All existing partitions and data will be lost.
>  	  <br><br>
>  	</td>
> @@ -46,7 +46,7 @@
>  	<td valign="top" width="30"><img src="plus.png"></td>
>  	<td valign="top" width="560"><b>Graphical user interface</b><br>
>  	  Final configuration will be done on the graphical user
> -	  interface via a web browser.
> +	  interface, via a web browser.
>  	  <br><br>
>  	</td>
>        </tr>
> diff --git a/html-pve/passwd.htm b/html-pve/passwd.htm
> index b1a8522..1c7d2fc 100644
> --- a/html-pve/passwd.htm
> +++ b/html-pve/passwd.htm
> @@ -16,9 +16,9 @@
>      <td colspan="2" valign="top" width="400"><br><p>
>      <table>
>        <tr><td><b>Proxmox Virtual Environment</b> is a
> -	full featured highly secure GNU/Linux system based on Debian.
> +	full featured, highly secure GNU/Linux system, based on Debian.
>  	<br><br>
> -        Please provide the <i>root</i> password in this step.
> +        In this step, please provide the <i>root</i> password.
>        </td></tr>
>      </table>
>    </p></td>
> @@ -27,8 +27,8 @@
>        <tr>
>  	<td valign="top" width="30"><img src="plus.png"></td>
>  	<td valign="top"><b>Password:</b>
> -	  Please use a strong password. It should have 8 or more characters.
> -	  Also combine letters, numbers, and symbols.
> +	  Please use a strong password. It should be at least 8 characters long,
> +	  and contain a combination of letters, numbers, and symbols.
>  	  <br><br>
>  	</td>
>        </tr>
> @@ -43,7 +43,7 @@
>        </tr>
>        <tr>
>  	<td valign="top" width="30"></td>
> -	<td valign="top">Press the Next button to continue installation.</td>
> +	<td valign="top">Press the Next button to continue the installation.</td>
>        </tr>
>      </table>
>    </p></td>
> diff --git a/html-pve/tags b/html-pve/tags
> new file mode 100644
> index 0000000..408de88
> --- /dev/null
> +++ b/html-pve/tags
> @@ -0,0 +1 @@
> +!_TAG_FILE_SORTED	2	/0=unsorted, 1=sorted, 2=foldcase/
> 





      reply	other threads:[~2020-12-10 19:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26  9:29 Dylan Whyte
2020-12-10 19:09 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b20c236d-ec0a-cfcd-7c56-d38314586022@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.whyte@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal