public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Oguz Bektas <o.bektas@proxmox.com>
Subject: [pve-devel] applied: [PATCH kernel-meta] boot-tool: fix whitespace in generated loader configuration
Date: Thu, 11 Nov 2021 11:20:56 +0100	[thread overview]
Message-ID: <b1e513c0-77eb-4fb5-6e73-1d3971be6764@proxmox.com> (raw)
In-Reply-To: <20211110130746.1025299-1-o.bektas@proxmox.com>

On 10.11.21 14:07, Oguz Bektas wrote:
> issue reported in forum [0]
> 
> seems like it came in with 2a8a4b5e37e87a0a994fe3820b015e051e6259fb
> 
> [0]: https://forum.proxmox.com/threads/problem-with-proxmox-boot-tool.99043/
> 
> before:
> ========
> $ cat /mnt/foo/loader/entries/proxmox-5.11.22-7-pve.conf
> title    Proxmox Virtual Environment
> version  5.11.22-7-pve
> options   root=ZFS=rpool/ROOT/pve-1 boot=zfs iommu=pt
>     linux    /EFI/proxmox/5.11.22-7-pve/vmlinuz-5.11.22-7-pve
>     initrd   /EFI/proxmox/5.11.22-7-pve/initrd.img-5.11.22-7-pve
> 
> after:
> ========
> $ proxmox-boot-tool refresh
> $  cat /mnt/foo/loader/entries/proxmox-5.11.22-7-pve.conf
> title    Proxmox Virtual Environment
> version  5.11.22-7-pve
> options   root=ZFS=rpool/ROOT/pve-1 boot=zfs iommu=pt
> linux    /EFI/proxmox/5.11.22-7-pve/vmlinuz-5.11.22-7-pve
> initrd   /EFI/proxmox/5.11.22-7-pve/initrd.img-5.11.22-7-pve
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  proxmox-boot/zz-proxmox-boot | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, but reworked the commit message to clarify that this has no actual functional
impact (but still good to have to avoid confusion), thanks!




      parent reply	other threads:[~2021-11-11 10:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 13:07 [pve-devel] " Oguz Bektas
2021-11-10 14:19 ` Stoiko Ivanov
2021-11-11 10:20 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1e513c0-77eb-4fb5-6e73-1d3971be6764@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=o.bektas@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal