Re: [pve-devel] [PATCH installer 6/6] fix #5811: auto: add option to retrieve FQDN from DHCP configuration

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 01.04.25 um 15:44 schrieb Daniel Kral:
> On 4/1/25 15:29, Stefan Hanreich wrote:
>> On 4/1/25 15:25, Christoph Heiss wrote:
>>> The file directly from `git format-patch` looks fine, with no extra
>>> newlines. Sent the patches using `git send-email` as usual, so not sure
>>> where it went wrong.
>>> I'll see if I can reproduce it locally for me and fix it up for a v2.
>>
>> I think this happened for me as well once with the firewall patch series
>> and the mailing list trims / truncates overly long lines iirc.
> 
> Hm, interesting! Just checked against the patch that created the JSON 
> file [0] seems fine there, but admittedly the patch there is encoded in 
> base64, could that be a reason for this?
> 
> [0] 
> https://lore.proxmox.com/pve-devel/20240417123108.212720-14-a.lauterer@proxmox.com/

Welcome to the world of email ;-)

SMTP (RFC 2822, replaced by 5322, but same holds true) dictates:

   There are two limits that this specification places on the number of
   characters in a line.  Each line of characters MUST be no more than
   998 characters, and SHOULD be no more than 78 characters, excluding
   the CRLF.

And yes, encoding a message as base64 avoids this as these can be
wrapped at any point, thus avoiding long line lengths in the transport
of the message while allowing longer ones in the message itself.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel