public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH proxmox-perl-rs] common: buildsys: Makefile: drop `--no-pre-clean`
       [not found] <20240927134831.2655916-1-jing@jing.rocks>
@ 2024-09-27 13:45 ` Jing Luo via pve-devel
  2024-11-11 10:41 ` [pve-devel] applied: [PATCH proxmox-perl-rs] common: d/control: change binary package architecture from `any` to `all` Thomas Lamprecht
       [not found] ` <20240927134831.2655916-2-jing@jing.rocks>
  2 siblings, 0 replies; 3+ messages in thread
From: Jing Luo via pve-devel @ 2024-09-27 13:45 UTC (permalink / raw)
  To: pve-devel; +Cc: Jing Luo

[-- Attachment #1: Type: message/rfc822, Size: 5175 bytes --]

From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH proxmox-perl-rs] common: buildsys: Makefile: drop `--no-pre-clean`
Date: Fri, 27 Sep 2024 22:45:53 +0900
Message-ID: <20240927134831.2655916-2-jing@jing.rocks>

There is no difference in the source or binary packge running with or
without `--no-pre-clean`. On the other hand, dpkg-buildpackge complains
loudly when `--no-pre-clean` is specified, so let's remove it.

Signed-off-by: Jing Luo <jing@jing.rocks>
---
 common/pkg/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/pkg/Makefile b/common/pkg/Makefile
index 1e5cf1d..cbefdf7 100644
--- a/common/pkg/Makefile
+++ b/common/pkg/Makefile
@@ -51,7 +51,7 @@ $(BUILDDIR): debian PVE Proxmox Makefile
 .PHONY: deb
 deb: $(DEB)
 $(DEB): $(BUILDDIR)
-	cd $(BUILDDIR); dpkg-buildpackage -b -us -uc --no-pre-clean
+	cd $(BUILDDIR); dpkg-buildpackage -b -us -uc
 	lintian $(DEB)
 
 .PHONY: dsc
-- 
2.46.2




[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH proxmox-perl-rs] common: d/control: change binary package architecture from `any` to `all`
       [not found] <20240927134831.2655916-1-jing@jing.rocks>
  2024-09-27 13:45 ` [pve-devel] [PATCH proxmox-perl-rs] common: buildsys: Makefile: drop `--no-pre-clean` Jing Luo via pve-devel
@ 2024-11-11 10:41 ` Thomas Lamprecht
       [not found] ` <20240927134831.2655916-2-jing@jing.rocks>
  2 siblings, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2024-11-11 10:41 UTC (permalink / raw)
  To: Jing Luo, pve-devel

Am 27.09.24 um 15:45 schrieb Jing Luo:
> There is no architecture dependent binary files in the libproxmox-rs-perl deb
> package. There is no shared libs either (says debhelper), so let's remove
> that too. Slight adjustment for Makefile too.
> 
> Signed-off-by: Jing Luo <jing@jing.rocks>
> ---
> This can improve portability. Let's go baby
> ---
>  common/pkg/Makefile       | 2 +-
>  common/pkg/debian/control | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH proxmox-perl-rs] common: buildsys: Makefile: drop `--no-pre-clean`
       [not found] ` <20240927134831.2655916-2-jing@jing.rocks>
@ 2024-11-11 10:42   ` Thomas Lamprecht
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2024-11-11 10:42 UTC (permalink / raw)
  To: Jing Luo, pve-devel

Am 27.09.24 um 15:45 schrieb Jing Luo:
> There is no difference in the source or binary packge running with or
> without `--no-pre-clean`. On the other hand, dpkg-buildpackge complains
> loudly when `--no-pre-clean` is specified, so let's remove it.
> 
> Signed-off-by: Jing Luo <jing@jing.rocks>
> ---
>  common/pkg/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-11-11 10:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20240927134831.2655916-1-jing@jing.rocks>
2024-09-27 13:45 ` [pve-devel] [PATCH proxmox-perl-rs] common: buildsys: Makefile: drop `--no-pre-clean` Jing Luo via pve-devel
2024-11-11 10:41 ` [pve-devel] applied: [PATCH proxmox-perl-rs] common: d/control: change binary package architecture from `any` to `all` Thomas Lamprecht
     [not found] ` <20240927134831.2655916-2-jing@jing.rocks>
2024-11-11 10:42   ` [pve-devel] applied: [PATCH proxmox-perl-rs] common: buildsys: Makefile: drop `--no-pre-clean` Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal