[pve-devel] [PATCH qemu-server] clone: remove outdated TODO about bandwidth limit

[pve-devel] [PATCH qemu-server] clone: remove outdated TODO about bandwidth limit

[Fiona Ebner]

Respecting bandwidth limit for offline clone was implemented by commit
56d16f16 ("fix #4249: make image clone or conversion respect bandwidth
limit"). It's still not respected for EFI disks, but those are small,
so just ignore it.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Would've applied it directly, but am not 100% sure about the EFI disk
- technically, we'd need to apply the limit there too, but seems not
really worth the effort (qemu-img dd doesn't have the option) - so
sending it for discussion.

 PVE/QemuServer.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index abb6221e..40be44db 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -8087,7 +8087,6 @@ sub clone_disk {
 	    qemu_drive_mirror($vmid, $src_drivename, $newvolid, $newvmid, $sparseinit, $jobs,
 	        $completion, $qga, $bwlimit);
 	} else {
-	    # TODO: handle bwlimits
 	    if ($dst_drivename eq 'efidisk0') {
 		# the relevant data on the efidisk may be smaller than the source
 		# e.g. on RBD/ZFS, so we use dd to copy only the amount
-- 
2.30.2

[pve-devel] applied: [PATCH qemu-server] clone: remove outdated TODO about bandwidth limit

[Thomas Lamprecht]

Am 24/02/2023 um 08:37 schrieb Fiona Ebner:
> Respecting bandwidth limit for offline clone was implemented by commit
> 56d16f16 ("fix #4249: make image clone or conversion respect bandwidth
> limit"). It's still not respected for EFI disks, but those are small,
> so just ignore it.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Would've applied it directly, but am not 100% sure about the EFI disk
> - technically, we'd need to apply the limit there too, but seems not
> really worth the effort (qemu-img dd doesn't have the option) - so
> sending it for discussion.
> 
>  PVE/QemuServer.pm | 1 -
>  1 file changed, 1 deletion(-)
> 
>

applied, thanks!