From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] clone: remove outdated TODO about bandwidth limit
Date: Fri, 24 Feb 2023 08:56:34 +0100 [thread overview]
Message-ID: <b040f58d-a9cb-c1a4-f061-284014cee9b8@proxmox.com> (raw)
In-Reply-To: <20230224073739.5728-1-f.ebner@proxmox.com>
Am 24/02/2023 um 08:37 schrieb Fiona Ebner:
> Respecting bandwidth limit for offline clone was implemented by commit
> 56d16f16 ("fix #4249: make image clone or conversion respect bandwidth
> limit"). It's still not respected for EFI disks, but those are small,
> so just ignore it.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Would've applied it directly, but am not 100% sure about the EFI disk
> - technically, we'd need to apply the limit there too, but seems not
> really worth the effort (qemu-img dd doesn't have the option) - so
> sending it for discussion.
>
> PVE/QemuServer.pm | 1 -
> 1 file changed, 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-02-24 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 7:37 [pve-devel] " Fiona Ebner
2023-02-24 7:56 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b040f58d-a9cb-c1a4-f061-284014cee9b8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox