public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox v2 1/8] serde: implement ini serializer
Date: Tue, 24 Mar 2026 14:08:59 +0100	[thread overview]
Message-ID: <avrncyecfvs7kzpgxcijy2hllmc7qyqa2bb4ysfny6lcsmfjl3@5hg6lf2wwxzs> (raw)
In-Reply-To: <867329b9-bebe-4c6d-8d0e-3f33e220c235@proxmox.com>

On Tue, Mar 24, 2026 at 12:13:05PM +0100, Thomas Lamprecht wrote:
> Am 13.02.26 um 15:36 schrieb Christoph Heiss:
> > The official WireGuard tooling wg(8) uses a (mostly) INI-like format
> > for consuming configuration.
> > 
> > E.g. `wg syncconf` will be used by in the future by the WireGuard fabric
> > for applying changes to a particular WireGuard interface.
> > 
> > One of the quirks of the INI format used by wg(8) are that there can be
> > multiple sections with the same name, which is also explicitly supported
> > by this serializer.

Does that last part even *need* explicit support?

> 
> Any technical reason for this to be in proxmox-serde over a dedicated
> crate? like proxmox-ini or proxmox-ini-config or the like?
> 
> proxmox-serde is currently a bit of a mixed bag, but might be better
> for more for generic serde helper that should be mostly provived by
> upstream in some ideal world (from our POV).
> 
> @Wolfgang: any opinion here.

Yeah so it's mostly perl and "should be in serde or serde_json" right
now and re-exports some of the `proxmox-base64` modules as well. The
last part is something we could probably discuss further, especially
given the array-as-base64 patch - perhaps the reexports should be
dropped and all base64 related stuff in the proxmox-base64 crate...
(This was initially mostly kept to limit the API breakage a bit...)

Anyway, this definitely should not be in here.




  reply	other threads:[~2026-03-24 13:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 14:35 [PATCH proxmox v2 0/8] sdn: add wireguard fabric configuration support Christoph Heiss
2026-02-13 14:35 ` [PATCH proxmox v2 1/8] serde: implement ini serializer Christoph Heiss
2026-03-24 11:13   ` Thomas Lamprecht
2026-03-24 13:08     ` Wolfgang Bumiller [this message]
2026-03-25 11:40     ` Christoph Heiss
2026-03-25 12:17       ` Thomas Lamprecht
2026-03-25 18:02         ` Christoph Heiss
2026-03-24 15:14   ` Wolfgang Bumiller
2026-02-13 14:35 ` [PATCH proxmox v2 2/8] serde: add base64 module for byte arrays Christoph Heiss
2026-03-24 12:57   ` Wolfgang Bumiller
2026-02-13 14:35 ` [PATCH proxmox v2 3/8] network-types: add ServiceEndpoint type as host/port tuple abstraction Christoph Heiss
2026-02-13 14:35 ` [PATCH proxmox v2 4/8] schema: provide integer schema for node ports Christoph Heiss
2026-02-13 14:35 ` [PATCH proxmox v2 5/8] schema: api-types: add ed25519 base64 encoded key schema Christoph Heiss
2026-02-13 14:35 ` [PATCH proxmox v2 6/8] wireguard: init configuration support crate Christoph Heiss
2026-02-13 14:36 ` [PATCH proxmox v2 7/8] wireguard: implement api for PublicKey Christoph Heiss
2026-02-13 14:36 ` [PATCH proxmox v2 8/8] wireguard: make per-peer preshared key optional Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avrncyecfvs7kzpgxcijy2hllmc7qyqa2bb4ysfny6lcsmfjl3@5hg6lf2wwxzs \
    --to=w.bumiller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal