Re: [PATCH proxmox-ve-rs v7 02/21] frr: add proxmox-frr-templates package that contains templates

[Gabriel Goller <g.goller@proxmox.com>]

On 27.03.2026 10:07, Gabriel Goller wrote:
> On 26.03.2026 16:15, Shannon Sterz wrote:
> > On Mon Mar 23, 2026 at 2:48 PM CET, Gabriel Goller wrote:
> > > This debian package contains the jinja template files used to generate
> > > the frr config. Currently only the fabrics template files are here, the
> > > rest will be added in later commits. When installing this package the
> > > templates will be installed to `/usr/share/proxmox-frr/templates/`.
> > > `proxmox-frr` will then use `include_str!` to embed the templates into
> > > the binary.
> > >
> > > This package will only be published to the `devel` channel.
> > >
> > > Reviewed-by: Hannes Laimer <h.laimer@proxmox.com>
> > > Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>
> > > Co-authored-by: Stefan Hanreich <s.hanreich@proxmox.com>
> > > Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> > > ---
> > >  Makefile                                      |  8 +++
> > >  proxmox-frr-templates/.gitignore              |  1 +
> > >  proxmox-frr-templates/Makefile                | 50 +++++++++++++++++++
> > >  proxmox-frr-templates/debian/changelog        |  5 ++
> > >  proxmox-frr-templates/debian/control          | 17 +++++++
> > >  proxmox-frr-templates/debian/copyright        | 18 +++++++
> > >  .../debian/proxmox-frr-templates.install      |  1 +
> > >  proxmox-frr-templates/debian/rules            |  5 ++
> > >  .../templates/access_lists.jinja              |  6 +++
> > >  proxmox-frr-templates/templates/fabricd.jinja | 29 +++++++++++
> > >  .../templates/frr.conf.jinja                  |  5 ++
> > >  .../templates/interface.jinja                 | 12 +++++
> > >  proxmox-frr-templates/templates/ospfd.jinja   | 18 +++++++
> > >  .../templates/protocol_routemaps.jinja        | 10 ++++
> > >  .../templates/route_maps.jinja                | 22 ++++++++
> > >  15 files changed, 207 insertions(+)
> > >  create mode 100644 proxmox-frr-templates/.gitignore
> > >  create mode 100644 proxmox-frr-templates/Makefile
> > >  create mode 100644 proxmox-frr-templates/debian/changelog
> > >  create mode 100644 proxmox-frr-templates/debian/control
> > >  create mode 100644 proxmox-frr-templates/debian/copyright
> > >  create mode 100644 proxmox-frr-templates/debian/proxmox-frr-templates.install
> > >  create mode 100755 proxmox-frr-templates/debian/rules
> > >  create mode 100644 proxmox-frr-templates/templates/access_lists.jinja
> > >  create mode 100644 proxmox-frr-templates/templates/fabricd.jinja
> > >  create mode 100644 proxmox-frr-templates/templates/frr.conf.jinja
> > >  create mode 100644 proxmox-frr-templates/templates/interface.jinja
> > >  create mode 100644 proxmox-frr-templates/templates/ospfd.jinja
> > >  create mode 100644 proxmox-frr-templates/templates/protocol_routemaps.jinja
> > >  create mode 100644 proxmox-frr-templates/templates/route_maps.jinja
> > >
> > > [snip]
> > > diff --git a/proxmox-frr-templates/debian/copyright b/proxmox-frr-templates/debian/copyright
> > > new file mode 100644
> > > index 000000000000..1ea8a56b4f58
> > > --- /dev/null
> > > +++ b/proxmox-frr-templates/debian/copyright
> > > @@ -0,0 +1,18 @@
> > > +Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
> > > +
> > > +Files:
> > > + *
> > > +Copyright: 2019 - 2025 Proxmox Server Solutions GmbH <support@proxmox.com>
> > 
> > tiny nit: but it's 2026 already ;)
> 
> Fixed it, thanks for the review!

Oh, I noticed every crate in ve-rs is on 2025. Should I update them all?
Or do we only update the new crates (so proxmox-frr-templates)?
@Thomas?

> > > +License: AGPL-3.0-or-later
> > > + This program is free software: you can redistribute it and/or modify it under
> > > + the terms of the GNU Affero General Public License as published by the Free
> > > + Software Foundation, either version 3 of the License, or (at your option) any
> > > + later version.
> > > + .
> > > + This program is distributed in the hope that it will be useful, but WITHOUT
> > > + ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
> > > + FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more
> > > + details.
> > > + .
> > > + You should have received a copy of the GNU Affero General Public License along
> > > + with this program. If not, see <https://www.gnu.org/licenses/>.