From: Gabriel Goller <g.goller@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager/network v2 0/2] sdn: add guest/nic selectors to IPAM create window
Date: Wed, 26 Aug 2026 13:43:50 +0200 [thread overview]
Message-ID: <ao7REa0yzMlHlWtv@luna.proxmox.com> (raw)
In-Reply-To: <20260826111322.1111478-1-h.laimer@proxmox.com>
Small nit: the submitValue property doesn't need to be in the cBind, we could
just always set it to true.
LGTM though.
Tested-by: Gabriel Goller <g.goller@proxmox.com>
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
next prev parent reply other threads:[~2026-08-26 11:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 11:13 [PATCH manager/network v2 0/2] sdn: add guest/nic selectors to IPAM create window Hannes Laimer
2026-08-26 11:13 ` [PATCH pve-network v2 1/2] api: sdn: ipam: add optional vmid to POST endpoint Hannes Laimer
2026-08-26 11:13 ` [PATCH pve-manager v2 2/2] ui: sdn: ipam: allow picking the nic instead of typing its MAC Hannes Laimer
2026-08-26 11:43 ` Gabriel Goller [this message]
2026-08-26 12:16 ` [PATCH manager/network v2 0/2] sdn: add guest/nic selectors to IPAM create window Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao7REa0yzMlHlWtv@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox