From: Christoph Heiss <c.heiss@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH installer v2 2/7] gui: expand ip address Gtk3::Entry
Date: Wed, 20 Dec 2023 10:40:20 +0100 [thread overview]
Message-ID: <ams2wu6jpb5yt37tgxmc6qe5uefatyeilm2sgiymhezofbfeak@bbxs7xavwacg> (raw)
In-Reply-To: <s8ov88zr1xd.fsf@proxmox.com>
On Fri, Dec 15, 2023 at 03:08:48PM +0100, Maximiliano Sandoval wrote:
>
>
> Christoph Heiss <c.heiss@proxmox.com> writes:
>
> > On Tue, Nov 21, 2023 at 04:10:20PM +0100, Maximiliano Sandoval wrote:
> >>
> >> This accounts for the different layout set in the previous commit.
> >
> > What commit is meant here exactly? The previous patch in this series
> > (aka. the first) does not change any layout as it's a simple code move,
> > right?
> >
>
> Good catch, in v1 this commit went directly after the commit
>
> gui: use basic grid in the network panel
Makes sense then, I figured that.
>
> which contains the mentioned changes. Should this require a v3?
From my side, no, if nothing else comes up. If really needed it could be
fixed up when committing at the very latest.
>
> --
> Maximiliano
next prev parent reply other threads:[~2023-12-20 9:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 15:10 [pve-devel] [PATCH installer v2 0/7] gui: use gtk grids when possible Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 1/7] gui: move create_basic_grid subroutine definition up Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 2/7] gui: expand ip address Gtk3::Entry Maximiliano Sandoval
2023-12-15 12:06 ` Christoph Heiss
2023-12-15 14:08 ` Maximiliano Sandoval
2023-12-20 9:40 ` Christoph Heiss [this message]
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 3/7] gui: use basic grid in password panel Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 4/7] gui: use basic grid in country/timezone panel Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 5/7] gui: change margins in create_basic_grid Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 6/7] gui: use basic grid in the network panel Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 7/7] gui: remove trailing spaces and colons Maximiliano Sandoval
2023-12-14 13:58 ` [pve-devel] [PATCH installer v2 0/7] gui: use gtk grids when possible Maximiliano Sandoval
2023-12-15 8:50 ` Lukas Wagner
2023-12-15 12:08 ` Christoph Heiss
2024-01-08 10:47 ` Maximiliano Sandoval
2024-02-14 13:32 ` Maximiliano Sandoval
2024-02-22 13:31 ` Maximiliano Sandoval
2024-02-23 13:16 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ams2wu6jpb5yt37tgxmc6qe5uefatyeilm2sgiymhezofbfeak@bbxs7xavwacg \
--to=c.heiss@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox