public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH firewall] fix #4175: ignore non-filter ebtables tables
Date: Mon, 29 Aug 2022 14:32:03 +0200	[thread overview]
Message-ID: <afc757f5-9408-6bf1-28af-6bce61154c87@proxmox.com> (raw)
In-Reply-To: <20220727130752.1175497-1-f.gruenbichler@proxmox.com>

Am 27/07/2022 um 15:07 schrieb Fabian Grünbichler:
> we only ever add rules to the filter table, without this we'd add all
> rules from other tables (which might have been manually filled by the
> admin) to the filter table as well - adding another copy on every
> iteration of the firewall update cycle!
> 
> note that ebtables-restore seems to flush tables contained in its input,
> but leave those alone which are not referenced at all.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> still waiting on OP to report whether there is yet another issue
> observed which is unrelated to ebtables - but this (wrong) behaviour I
> can reproduce, and it is fixed with this patch ;)
> 
>  src/PVE/Firewall.pm | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
>

applied, thanks!




      reply	other threads:[~2022-08-29 12:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-27 13:07 [pve-devel] " Fabian Grünbichler
2022-08-29 12:32 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afc757f5-9408-6bf1-28af-6bce61154c87@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal