public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	"f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] qcow2: increase cache-size to 1GB
Date: Thu, 2 Oct 2025 11:39:47 +0200	[thread overview]
Message-ID: <afb7881b-1e9d-4446-bf9e-5783902b90eb@proxmox.com> (raw)
In-Reply-To: <mailman.75.1755169848.385.pve-devel@lists.proxmox.com>

Am 14.08.25 um 1:10 PM schrieb DERUMIER, Alexandre via pve-devel:
>>> we also know the image size here, so we could use a capped, derived
>>> value?

Yes, I'd also be in favor of using something calculated from the size.
We could additionally add a drive configuration option to override the
value if we really want to.

>>>
>>> what if the disk is resized? 
> 
> One problem is disk resize, because the cache size can't be increase
> without restart. That's why I think it's better to use a big cache
> size.(It's really a max value) 

But the max value might even be reached for relatively small disks. And
there are users that have a lot of VMs with rather small disks. For
them, the increase in memory consumption would be quite big I suppose!

Resizing a disk in a way that changes the order of magnitude of its size
is rather uncommon, so I don't see an issue of not having a perfect
cache size after such a resize.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-10-02  9:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 13:46 Alexandre Derumier via pve-devel
2025-08-13 14:25 ` Fabian Grünbichler
2025-08-14 11:10   ` DERUMIER, Alexandre via pve-devel
2025-08-14 14:14     ` DERUMIER, Alexandre via pve-devel
2025-10-02  9:39     ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afb7881b-1e9d-4446-bf9e-5783902b90eb@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal