From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH access-control v2] add missing paths in check_path
Date: Wed, 16 Jun 2021 16:27:54 +0200 [thread overview]
Message-ID: <aedee362-aca3-a6c0-6123-19ac871378f0@proxmox.com> (raw)
In-Reply-To: <20210616135534.4798-1-d.csapak@proxmox.com>
On 16.06.21 15:55, Dominik Csapak wrote:
> * /access/realm/<realm>
> * /access/groups/<group>
>
> were overlooked when fixing #1500
>
> see: https://forum.proxmox.com/threads/are-group-acls-broken-in-v6-4.91000/
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> supersedes my earlier patch:
> https://lists.proxmox.com/pipermail/pve-devel/2021-June/048704.html
>
> changes:
> * also add missing group paths
>
> src/PVE/AccessControl.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm
> index 888875e..9619c7d 100644
> --- a/src/PVE/AccessControl.pm
> +++ b/src/PVE/AccessControl.pm
> @@ -939,7 +939,9 @@ sub check_path {
> /
> |/access
> |/access/groups
> + |/access/groups/[[:alnum:]\.\-\_]+
> |/access/realm
> + |/access/realm/[[:alnum:]\.\-\_]+
> |/nodes
> |/nodes/[[:alnum:]\.\-\_]+
> |/pool
>
also backported to stable-6, and those sub-paths are missing in the UI's
"path proposal" generator for the combobox's store, can you please send a
patch to add them there too (master only)?
prev parent reply other threads:[~2021-06-16 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 13:55 Dominik Csapak
2021-06-16 14:19 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-16 14:27 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aedee362-aca3-a6c0-6123-19ac871378f0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox