public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
	pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH qemu-server] vm status: make sure disk{read, write} adhere to return schema to fix regression for PDM
Date: Tue, 25 Nov 2025 11:30:35 +0100	[thread overview]
Message-ID: <ae0578fe-3a6d-41bf-af5f-aaa98d33ecd4@proxmox.com> (raw)
In-Reply-To: <176113381638.505211.14885999192908333519.b4-ty@proxmox.com>

Am 22.10.25 um 1:50 PM schrieb Fabian Grünbichler:
> 
> On Wed, 22 Oct 2025 12:41:15 +0200, Fiona Ebner wrote:
>> As reported in the community forum [0], Proxmox Datacenter Manager
>> will fail to handle the result of the status API call for a shut down
>> VM. The reason is that the return schema requires having an integer
>> return value for disk{read,write}, so an explicit undef is not
>> allowed. However, the properties are optional and are not relevant for
>> a shut down guest, so just don't set them at all if no value was
>> queried. This also makes sure that bug #6207 does not reappear. Note
>> that pvestatd would already not consider the value for shut down VMs
>> and treats the value not being present and the value being an explicit
>> undef the same, see update_qemu_status() in pvestatd.pm.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] vm status: make sure disk{read, write} adhere to return schema to fix regression for PDM
>       commit: 069d8a6e14d9524ae3f2c57ba7af3668721ddbc5
> 
> Best regards,


Also applied this for stable-bookworm now, because it fixes the
corresponding backport:

Fixes: 452aa74e ("fix #6207: vm status: return undef values when
disk{read, write} cannot be queried")

Applied as:
vm status: make sure disk{read, write} adhere to return schema to fix
regression for PDM
commit: 3dec388c20a50b0240b65cc8ba67c1fe1571804a


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

      reply	other threads:[~2025-11-25 10:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22 10:41 [pve-devel] " Fiona Ebner
2025-10-22 11:50 ` [pve-devel] applied: " Fabian Grünbichler
2025-11-25 10:30   ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae0578fe-3a6d-41bf-af5f-aaa98d33ecd4@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal